audit: don't free_chunk() after fsnotify_add_mark()
Don't do free_chunk() after fsnotify_add_mark(). That one does a delayed unref via the destroy list and this results in use-after-free. Signed-off-by: Miklos Szeredi <mszeredi@suse.cz> Acked-by: Eric Paris <eparis@redhat.com> CC: stable@vger.kernel.org
This commit is contained in:
Родитель
ddf343f635
Коммит
0fe33aae0e
|
@ -259,7 +259,7 @@ static void untag_chunk(struct node *p)
|
|||
|
||||
fsnotify_duplicate_mark(&new->mark, entry);
|
||||
if (fsnotify_add_mark(&new->mark, new->mark.group, new->mark.i.inode, NULL, 1)) {
|
||||
free_chunk(new);
|
||||
fsnotify_put_mark(&new->mark);
|
||||
goto Fallback;
|
||||
}
|
||||
|
||||
|
@ -322,7 +322,7 @@ static int create_chunk(struct inode *inode, struct audit_tree *tree)
|
|||
|
||||
entry = &chunk->mark;
|
||||
if (fsnotify_add_mark(entry, audit_tree_group, inode, NULL, 0)) {
|
||||
free_chunk(chunk);
|
||||
fsnotify_put_mark(entry);
|
||||
return -ENOSPC;
|
||||
}
|
||||
|
||||
|
@ -396,7 +396,7 @@ static int tag_chunk(struct inode *inode, struct audit_tree *tree)
|
|||
fsnotify_duplicate_mark(chunk_entry, old_entry);
|
||||
if (fsnotify_add_mark(chunk_entry, chunk_entry->group, chunk_entry->i.inode, NULL, 1)) {
|
||||
spin_unlock(&old_entry->lock);
|
||||
free_chunk(chunk);
|
||||
fsnotify_put_mark(chunk_entry);
|
||||
fsnotify_put_mark(old_entry);
|
||||
return -ENOSPC;
|
||||
}
|
||||
|
|
Загрузка…
Ссылка в новой задаче