iio: adc: meson-saradc: fix potential crash in meson_sar_adc_clear_fifo
meson_sar_adc_clear_fifo passes a 0 as value-pointer to regmap_read().
In case of the meson-saradc driver this ends up in regmap_mmio_read(),
where the value-pointer is de-referenced unconditionally to assign the
value which was read.
Fix this by passing an actual pointer, even though all we want to do is
to discard the value.
As a side-effect this fixes a sparse warning ("Using plain integer as
NULL pointer") as reported by Paolo Cretaro.
Fixes: 3adbf34273
("iio: adc: add a driver for the SAR ADC found in Amlogic Meson SoCs")
Reported-by: Paolo Cretaro <paolocretaro@gmail.com>
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
This commit is contained in:
Родитель
1454e15bc2
Коммит
103a07d427
|
@ -468,13 +468,13 @@ static void meson_sar_adc_unlock(struct iio_dev *indio_dev)
|
||||||
static void meson_sar_adc_clear_fifo(struct iio_dev *indio_dev)
|
static void meson_sar_adc_clear_fifo(struct iio_dev *indio_dev)
|
||||||
{
|
{
|
||||||
struct meson_sar_adc_priv *priv = iio_priv(indio_dev);
|
struct meson_sar_adc_priv *priv = iio_priv(indio_dev);
|
||||||
int count;
|
unsigned int count, tmp;
|
||||||
|
|
||||||
for (count = 0; count < MESON_SAR_ADC_MAX_FIFO_SIZE; count++) {
|
for (count = 0; count < MESON_SAR_ADC_MAX_FIFO_SIZE; count++) {
|
||||||
if (!meson_sar_adc_get_fifo_count(indio_dev))
|
if (!meson_sar_adc_get_fifo_count(indio_dev))
|
||||||
break;
|
break;
|
||||||
|
|
||||||
regmap_read(priv->regmap, MESON_SAR_ADC_FIFO_RD, 0);
|
regmap_read(priv->regmap, MESON_SAR_ADC_FIFO_RD, &tmp);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Загрузка…
Ссылка в новой задаче