remoteproc: keystone: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20230504194453.1150368-5-u.kleine-koenig@pengutronix.de Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
This commit is contained in:
Родитель
94ea6edd49
Коммит
10f19fdeb6
|
@ -476,7 +476,7 @@ free_rproc:
|
|||
return ret;
|
||||
}
|
||||
|
||||
static int keystone_rproc_remove(struct platform_device *pdev)
|
||||
static void keystone_rproc_remove(struct platform_device *pdev)
|
||||
{
|
||||
struct keystone_rproc *ksproc = platform_get_drvdata(pdev);
|
||||
|
||||
|
@ -486,8 +486,6 @@ static int keystone_rproc_remove(struct platform_device *pdev)
|
|||
pm_runtime_disable(&pdev->dev);
|
||||
rproc_free(ksproc->rproc);
|
||||
of_reserved_mem_device_release(&pdev->dev);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
static const struct of_device_id keystone_rproc_of_match[] = {
|
||||
|
@ -501,7 +499,7 @@ MODULE_DEVICE_TABLE(of, keystone_rproc_of_match);
|
|||
|
||||
static struct platform_driver keystone_rproc_driver = {
|
||||
.probe = keystone_rproc_probe,
|
||||
.remove = keystone_rproc_remove,
|
||||
.remove_new = keystone_rproc_remove,
|
||||
.driver = {
|
||||
.name = "keystone-rproc",
|
||||
.of_match_table = keystone_rproc_of_match,
|
||||
|
|
Загрузка…
Ссылка в новой задаче