iommu/omap: Simplify omap2_iommu_fault_isr()
The function omap2_iommu_fault_isr() does an unnecessary recomputation of the return value. The logic relies on setting the same bit fields as the MMU fault error status bits, so simplify this function and remove the unneeded macros. These macros were originally exported to notify MMU faults to users prior to the IOMMU framework adaptation, but are now redundant. Signed-off-by: Suman Anna <s-anna@ti.com> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Joerg Roedel <jroedel@suse.de>
This commit is contained in:
Родитель
c2372aafbc
Коммит
124262a2ee
|
@ -53,13 +53,6 @@
|
||||||
((pgsz) == MMU_CAM_PGSZ_64K) ? 0xffff0000 : \
|
((pgsz) == MMU_CAM_PGSZ_64K) ? 0xffff0000 : \
|
||||||
((pgsz) == MMU_CAM_PGSZ_4K) ? 0xfffff000 : 0)
|
((pgsz) == MMU_CAM_PGSZ_4K) ? 0xfffff000 : 0)
|
||||||
|
|
||||||
/* IOMMU errors */
|
|
||||||
#define OMAP_IOMMU_ERR_TLB_MISS (1 << 0)
|
|
||||||
#define OMAP_IOMMU_ERR_TRANS_FAULT (1 << 1)
|
|
||||||
#define OMAP_IOMMU_ERR_EMU_MISS (1 << 2)
|
|
||||||
#define OMAP_IOMMU_ERR_TBLWALK_FAULT (1 << 3)
|
|
||||||
#define OMAP_IOMMU_ERR_MULTIHIT_FAULT (1 << 4)
|
|
||||||
|
|
||||||
static void __iommu_set_twl(struct omap_iommu *obj, bool on)
|
static void __iommu_set_twl(struct omap_iommu *obj, bool on)
|
||||||
{
|
{
|
||||||
u32 l = iommu_read_reg(obj, MMU_CNTL);
|
u32 l = iommu_read_reg(obj, MMU_CNTL);
|
||||||
|
@ -122,7 +115,6 @@ static void omap2_iommu_set_twl(struct omap_iommu *obj, bool on)
|
||||||
static u32 omap2_iommu_fault_isr(struct omap_iommu *obj, u32 *ra)
|
static u32 omap2_iommu_fault_isr(struct omap_iommu *obj, u32 *ra)
|
||||||
{
|
{
|
||||||
u32 stat, da;
|
u32 stat, da;
|
||||||
u32 errs = 0;
|
|
||||||
|
|
||||||
stat = iommu_read_reg(obj, MMU_IRQSTATUS);
|
stat = iommu_read_reg(obj, MMU_IRQSTATUS);
|
||||||
stat &= MMU_IRQ_MASK;
|
stat &= MMU_IRQ_MASK;
|
||||||
|
@ -134,19 +126,9 @@ static u32 omap2_iommu_fault_isr(struct omap_iommu *obj, u32 *ra)
|
||||||
da = iommu_read_reg(obj, MMU_FAULT_AD);
|
da = iommu_read_reg(obj, MMU_FAULT_AD);
|
||||||
*ra = da;
|
*ra = da;
|
||||||
|
|
||||||
if (stat & MMU_IRQ_TLBMISS)
|
|
||||||
errs |= OMAP_IOMMU_ERR_TLB_MISS;
|
|
||||||
if (stat & MMU_IRQ_TRANSLATIONFAULT)
|
|
||||||
errs |= OMAP_IOMMU_ERR_TRANS_FAULT;
|
|
||||||
if (stat & MMU_IRQ_EMUMISS)
|
|
||||||
errs |= OMAP_IOMMU_ERR_EMU_MISS;
|
|
||||||
if (stat & MMU_IRQ_TABLEWALKFAULT)
|
|
||||||
errs |= OMAP_IOMMU_ERR_TBLWALK_FAULT;
|
|
||||||
if (stat & MMU_IRQ_MULTIHITFAULT)
|
|
||||||
errs |= OMAP_IOMMU_ERR_MULTIHIT_FAULT;
|
|
||||||
iommu_write_reg(obj, stat, MMU_IRQSTATUS);
|
iommu_write_reg(obj, stat, MMU_IRQSTATUS);
|
||||||
|
|
||||||
return errs;
|
return stat;
|
||||||
}
|
}
|
||||||
|
|
||||||
static void omap2_tlb_read_cr(struct omap_iommu *obj, struct cr_regs *cr)
|
static void omap2_tlb_read_cr(struct omap_iommu *obj, struct cr_regs *cr)
|
||||||
|
|
Загрузка…
Ссылка в новой задаче