w1: don't allow arbitrary users to remove w1 devices
The search/pullup/add/remove device attributes were 0666 which would allow arbitrary users to affect the 1 wire bus. Change to 0664 to prevent that. I found this patch in the Android tree, apparently this has never been sent upstream so doing it now. Signed-off-by: Brian Swetland <swetland@google.com> Signed-off-by: Linus Walleij <linus.walleij@stericsson.com> Cc: Evgeniy Polyakov <johnpol@2ka.mipt.ru> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Родитель
f49d2eb314
Коммит
12aa4c6417
|
@ -517,10 +517,10 @@ static W1_MASTER_ATTR_RO(max_slave_count, S_IRUGO);
|
||||||
static W1_MASTER_ATTR_RO(attempts, S_IRUGO);
|
static W1_MASTER_ATTR_RO(attempts, S_IRUGO);
|
||||||
static W1_MASTER_ATTR_RO(timeout, S_IRUGO);
|
static W1_MASTER_ATTR_RO(timeout, S_IRUGO);
|
||||||
static W1_MASTER_ATTR_RO(pointer, S_IRUGO);
|
static W1_MASTER_ATTR_RO(pointer, S_IRUGO);
|
||||||
static W1_MASTER_ATTR_RW(search, S_IRUGO | S_IWUGO);
|
static W1_MASTER_ATTR_RW(search, S_IRUGO | S_IWUSR | S_IWGRP);
|
||||||
static W1_MASTER_ATTR_RW(pullup, S_IRUGO | S_IWUGO);
|
static W1_MASTER_ATTR_RW(pullup, S_IRUGO | S_IWUSR | S_IWGRP);
|
||||||
static W1_MASTER_ATTR_RW(add, S_IRUGO | S_IWUGO);
|
static W1_MASTER_ATTR_RW(add, S_IRUGO | S_IWUSR | S_IWGRP);
|
||||||
static W1_MASTER_ATTR_RW(remove, S_IRUGO | S_IWUGO);
|
static W1_MASTER_ATTR_RW(remove, S_IRUGO | S_IWUSR | S_IWGRP);
|
||||||
|
|
||||||
static struct attribute *w1_master_default_attrs[] = {
|
static struct attribute *w1_master_default_attrs[] = {
|
||||||
&w1_master_attribute_name.attr,
|
&w1_master_attribute_name.attr,
|
||||||
|
|
Загрузка…
Ссылка в новой задаче