bnx2i: use strlcpy() instead of memcpy() for strings
DRV_MODULE_VERSION here is "2.7.2.2" which is only 8 chars but we copy 12 bytes from the stack so it's a small information leak. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Michael Chan <mchan@broadcom.com> Acked-by: Eddie Wai <eddie.wai@broadcom.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Родитель
8f961faef7
Коммит
12aba9e797
|
@ -400,7 +400,7 @@ int bnx2i_get_stats(void *handle)
|
|||
if (!stats)
|
||||
return -ENOMEM;
|
||||
|
||||
memcpy(stats->version, DRV_MODULE_VERSION, sizeof(stats->version));
|
||||
strlcpy(stats->version, DRV_MODULE_VERSION, sizeof(stats->version));
|
||||
memcpy(stats->mac_add1 + 2, hba->cnic->mac_addr, ETH_ALEN);
|
||||
|
||||
stats->max_frame_size = hba->netdev->mtu;
|
||||
|
|
Загрузка…
Ссылка в новой задаче