dm cache policy smq: fix alloc_bitset check that always evaluates as false
static analysis by cppcheck has found a check on alloc_bitset that always evaluates as false and hence never finds an allocation failure: [drivers/md/dm-cache-policy-smq.c:1689]: (warning) Logical conjunction always evaluates to false: !EXPR && EXPR. Fix this by removing the incorrect mq->cache_hit_bits check Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Mike Snitzer <snitzer@redhat.com>
This commit is contained in:
Родитель
0a927c2f02
Коммит
134bf30c06
|
@ -1686,7 +1686,7 @@ static struct dm_cache_policy *smq_create(dm_cblock_t cache_size,
|
|||
|
||||
if (from_cblock(cache_size)) {
|
||||
mq->cache_hit_bits = alloc_bitset(from_cblock(cache_size));
|
||||
if (!mq->cache_hit_bits && mq->cache_hit_bits) {
|
||||
if (!mq->cache_hit_bits) {
|
||||
DMERR("couldn't allocate cache hit bitset");
|
||||
goto bad_cache_hit_bits;
|
||||
}
|
||||
|
|
Загрузка…
Ссылка в новой задаче