From 15019e9815a06b84870bfaf9ee1e8b75bf7ef6a6 Mon Sep 17 00:00:00 2001 From: Jiri Olsa Date: Mon, 23 Apr 2018 11:08:15 +0200 Subject: [PATCH] perf check-headers.sh: Simplify arguments passing Passing whole string instead of parsing them after. It simplifies things for the next patches, that adds another function call, which makes it hard to pass arguments in the correct shape. Signed-off-by: Jiri Olsa Cc: Alexander Shishkin Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/20180423090823.32309-2-jolsa@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/check-headers.sh | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/tools/perf/check-headers.sh b/tools/perf/check-headers.sh index 9aff89bc7535..88c5f9449809 100755 --- a/tools/perf/check-headers.sh +++ b/tools/perf/check-headers.sh @@ -59,13 +59,8 @@ check () { file=$1 shift - opts= - while [ -n "$*" ]; do - opts="$opts \"$1\"" - shift - done - cmd="diff $opts ../$file ../../$file > /dev/null" + cmd="diff $* ../$file ../../$file > /dev/null" test -f ../../$file && eval $cmd || echo "Warning: Kernel ABI header at 'tools/$file' differs from latest version at '$file'" >&2 @@ -83,7 +78,7 @@ for i in $HEADERS; do done # diff with extra ignore lines -check arch/x86/lib/memcpy_64.S -I "^EXPORT_SYMBOL" -I "^#include " -check arch/x86/lib/memset_64.S -I "^EXPORT_SYMBOL" -I "^#include " -check include/uapi/asm-generic/mman.h -I "^#include <\(uapi/\)*asm-generic/mman-common.h>" -check include/uapi/linux/mman.h -I "^#include <\(uapi/\)*asm/mman.h>" +check arch/x86/lib/memcpy_64.S '-I "^EXPORT_SYMBOL" -I "^#include "' +check arch/x86/lib/memset_64.S '-I "^EXPORT_SYMBOL" -I "^#include "' +check include/uapi/asm-generic/mman.h '-I "^#include <\(uapi/\)*asm-generic/mman-common.h>"' +check include/uapi/linux/mman.h '-I "^#include <\(uapi/\)*asm/mman.h>"'