net: remove unnecessary NET_ADDR_RANDOM "bitclean"
NET_ADDR_SET is set in dev_set_mac_address() no need to alter dev->addr_assign_type value in drivers. Signed-off-by: Jiri Pirko <jiri@resnulli.us> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Родитель
fbdeca2d77
Коммит
15c6ff3bc0
|
@ -647,7 +647,6 @@ static int bfin_mac_set_mac_address(struct net_device *dev, void *p)
|
||||||
if (netif_running(dev))
|
if (netif_running(dev))
|
||||||
return -EBUSY;
|
return -EBUSY;
|
||||||
memcpy(dev->dev_addr, addr->sa_data, dev->addr_len);
|
memcpy(dev->dev_addr, addr->sa_data, dev->addr_len);
|
||||||
dev->addr_assign_type &= ~NET_ADDR_RANDOM;
|
|
||||||
setup_mac_addr(dev->dev_addr);
|
setup_mac_addr(dev->dev_addr);
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
|
@ -472,7 +472,6 @@ static int atl1c_set_mac_addr(struct net_device *netdev, void *p)
|
||||||
|
|
||||||
memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len);
|
memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len);
|
||||||
memcpy(adapter->hw.mac_addr, addr->sa_data, netdev->addr_len);
|
memcpy(adapter->hw.mac_addr, addr->sa_data, netdev->addr_len);
|
||||||
netdev->addr_assign_type &= ~NET_ADDR_RANDOM;
|
|
||||||
|
|
||||||
atl1c_hw_set_mac_addr(&adapter->hw, adapter->hw.mac_addr);
|
atl1c_hw_set_mac_addr(&adapter->hw, adapter->hw.mac_addr);
|
||||||
|
|
||||||
|
|
|
@ -84,7 +84,6 @@ static int atlx_set_mac(struct net_device *netdev, void *p)
|
||||||
|
|
||||||
memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len);
|
memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len);
|
||||||
memcpy(adapter->hw.mac_addr, addr->sa_data, netdev->addr_len);
|
memcpy(adapter->hw.mac_addr, addr->sa_data, netdev->addr_len);
|
||||||
netdev->addr_assign_type &= ~NET_ADDR_RANDOM;
|
|
||||||
|
|
||||||
atlx_set_mac_addr(&adapter->hw);
|
atlx_set_mac_addr(&adapter->hw);
|
||||||
return 0;
|
return 0;
|
||||||
|
|
|
@ -3904,7 +3904,6 @@ int bnx2x_change_mac_addr(struct net_device *dev, void *p)
|
||||||
return rc;
|
return rc;
|
||||||
}
|
}
|
||||||
|
|
||||||
dev->addr_assign_type &= ~NET_ADDR_RANDOM;
|
|
||||||
memcpy(dev->dev_addr, addr->sa_data, dev->addr_len);
|
memcpy(dev->dev_addr, addr->sa_data, dev->addr_len);
|
||||||
|
|
||||||
if (netif_running(dev))
|
if (netif_running(dev))
|
||||||
|
|
|
@ -1459,7 +1459,6 @@ static int xgmac_set_mac_address(struct net_device *dev, void *p)
|
||||||
if (!is_valid_ether_addr(addr->sa_data))
|
if (!is_valid_ether_addr(addr->sa_data))
|
||||||
return -EADDRNOTAVAIL;
|
return -EADDRNOTAVAIL;
|
||||||
|
|
||||||
dev->addr_assign_type &= ~NET_ADDR_RANDOM;
|
|
||||||
memcpy(dev->dev_addr, addr->sa_data, dev->addr_len);
|
memcpy(dev->dev_addr, addr->sa_data, dev->addr_len);
|
||||||
|
|
||||||
xgmac_set_mac_addr(ioaddr, dev->dev_addr, 0);
|
xgmac_set_mac_addr(ioaddr, dev->dev_addr, 0);
|
||||||
|
|
|
@ -865,7 +865,6 @@ static int enic_set_mac_addr(struct net_device *netdev, char *addr)
|
||||||
}
|
}
|
||||||
|
|
||||||
memcpy(netdev->dev_addr, addr, netdev->addr_len);
|
memcpy(netdev->dev_addr, addr, netdev->addr_len);
|
||||||
netdev->addr_assign_type &= ~NET_ADDR_RANDOM;
|
|
||||||
|
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
|
@ -784,7 +784,6 @@ static int ethoc_set_mac_address(struct net_device *dev, void *addr)
|
||||||
ethoc_write(priv, MAC_ADDR1, (mac[0] << 8) | (mac[1] << 0));
|
ethoc_write(priv, MAC_ADDR1, (mac[0] << 8) | (mac[1] << 0));
|
||||||
|
|
||||||
memcpy(dev->dev_addr, mac, ETH_ALEN);
|
memcpy(dev->dev_addr, mac, ETH_ALEN);
|
||||||
dev->addr_assign_type &= ~NET_ADDR_RANDOM;
|
|
||||||
|
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
|
@ -1738,7 +1738,6 @@ static int igbvf_set_mac(struct net_device *netdev, void *p)
|
||||||
return -EADDRNOTAVAIL;
|
return -EADDRNOTAVAIL;
|
||||||
|
|
||||||
memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len);
|
memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len);
|
||||||
netdev->addr_assign_type &= ~NET_ADDR_RANDOM;
|
|
||||||
|
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
|
@ -627,7 +627,6 @@ static int pxa168_eth_set_mac_address(struct net_device *dev, void *addr)
|
||||||
if (!is_valid_ether_addr(sa->sa_data))
|
if (!is_valid_ether_addr(sa->sa_data))
|
||||||
return -EADDRNOTAVAIL;
|
return -EADDRNOTAVAIL;
|
||||||
memcpy(oldMac, dev->dev_addr, ETH_ALEN);
|
memcpy(oldMac, dev->dev_addr, ETH_ALEN);
|
||||||
dev->addr_assign_type &= ~NET_ADDR_RANDOM;
|
|
||||||
memcpy(dev->dev_addr, sa->sa_data, ETH_ALEN);
|
memcpy(dev->dev_addr, sa->sa_data, ETH_ALEN);
|
||||||
netif_addr_lock_bh(dev);
|
netif_addr_lock_bh(dev);
|
||||||
update_hash_table_mac_address(pep, oldMac, dev->dev_addr);
|
update_hash_table_mac_address(pep, oldMac, dev->dev_addr);
|
||||||
|
|
|
@ -1080,7 +1080,6 @@ static int ks8842_set_mac(struct net_device *netdev, void *p)
|
||||||
if (!is_valid_ether_addr(addr->sa_data))
|
if (!is_valid_ether_addr(addr->sa_data))
|
||||||
return -EADDRNOTAVAIL;
|
return -EADDRNOTAVAIL;
|
||||||
|
|
||||||
netdev->addr_assign_type &= ~NET_ADDR_RANDOM;
|
|
||||||
memcpy(netdev->dev_addr, mac, netdev->addr_len);
|
memcpy(netdev->dev_addr, mac, netdev->addr_len);
|
||||||
|
|
||||||
ks8842_write_mac_addr(adapter, mac);
|
ks8842_write_mac_addr(adapter, mac);
|
||||||
|
|
|
@ -1052,7 +1052,6 @@ static int ks8851_set_mac_address(struct net_device *dev, void *addr)
|
||||||
if (!is_valid_ether_addr(sa->sa_data))
|
if (!is_valid_ether_addr(sa->sa_data))
|
||||||
return -EADDRNOTAVAIL;
|
return -EADDRNOTAVAIL;
|
||||||
|
|
||||||
dev->addr_assign_type &= ~NET_ADDR_RANDOM;
|
|
||||||
memcpy(dev->dev_addr, sa->sa_data, ETH_ALEN);
|
memcpy(dev->dev_addr, sa->sa_data, ETH_ALEN);
|
||||||
return ks8851_write_mac_addr(dev);
|
return ks8851_write_mac_addr(dev);
|
||||||
}
|
}
|
||||||
|
|
|
@ -1237,7 +1237,6 @@ static int ks_set_mac_address(struct net_device *netdev, void *paddr)
|
||||||
struct sockaddr *addr = paddr;
|
struct sockaddr *addr = paddr;
|
||||||
u8 *da;
|
u8 *da;
|
||||||
|
|
||||||
netdev->addr_assign_type &= ~NET_ADDR_RANDOM;
|
|
||||||
memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len);
|
memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len);
|
||||||
|
|
||||||
da = (u8 *)netdev->dev_addr;
|
da = (u8 *)netdev->dev_addr;
|
||||||
|
|
|
@ -527,7 +527,6 @@ static int enc28j60_set_mac_address(struct net_device *dev, void *addr)
|
||||||
if (!is_valid_ether_addr(address->sa_data))
|
if (!is_valid_ether_addr(address->sa_data))
|
||||||
return -EADDRNOTAVAIL;
|
return -EADDRNOTAVAIL;
|
||||||
|
|
||||||
dev->addr_assign_type &= ~NET_ADDR_RANDOM;
|
|
||||||
memcpy(dev->dev_addr, address->sa_data, dev->addr_len);
|
memcpy(dev->dev_addr, address->sa_data, dev->addr_len);
|
||||||
return enc28j60_set_hw_macaddr(dev);
|
return enc28j60_set_hw_macaddr(dev);
|
||||||
}
|
}
|
||||||
|
|
|
@ -3025,7 +3025,6 @@ static int nv_set_mac_address(struct net_device *dev, void *addr)
|
||||||
|
|
||||||
/* synchronized against open : rtnl_lock() held by caller */
|
/* synchronized against open : rtnl_lock() held by caller */
|
||||||
memcpy(dev->dev_addr, macaddr->sa_data, ETH_ALEN);
|
memcpy(dev->dev_addr, macaddr->sa_data, ETH_ALEN);
|
||||||
dev->addr_assign_type &= ~NET_ADDR_RANDOM;
|
|
||||||
|
|
||||||
if (netif_running(dev)) {
|
if (netif_running(dev)) {
|
||||||
netif_tx_lock_bh(dev);
|
netif_tx_lock_bh(dev);
|
||||||
|
|
|
@ -1534,12 +1534,10 @@ static int octeon_mgmt_probe(struct platform_device *pdev)
|
||||||
|
|
||||||
mac = of_get_mac_address(pdev->dev.of_node);
|
mac = of_get_mac_address(pdev->dev.of_node);
|
||||||
|
|
||||||
if (mac && is_valid_ether_addr(mac)) {
|
if (mac && is_valid_ether_addr(mac))
|
||||||
memcpy(netdev->dev_addr, mac, ETH_ALEN);
|
memcpy(netdev->dev_addr, mac, ETH_ALEN);
|
||||||
netdev->addr_assign_type &= ~NET_ADDR_RANDOM;
|
else
|
||||||
} else {
|
|
||||||
eth_hw_addr_random(netdev);
|
eth_hw_addr_random(netdev);
|
||||||
}
|
|
||||||
|
|
||||||
p->phy_np = of_parse_phandle(pdev->dev.of_node, "phy-handle", 0);
|
p->phy_np = of_parse_phandle(pdev->dev.of_node, "phy-handle", 0);
|
||||||
|
|
||||||
|
|
|
@ -1831,7 +1831,6 @@ static int smsc911x_set_mac_address(struct net_device *dev, void *p)
|
||||||
if (!is_valid_ether_addr(addr->sa_data))
|
if (!is_valid_ether_addr(addr->sa_data))
|
||||||
return -EADDRNOTAVAIL;
|
return -EADDRNOTAVAIL;
|
||||||
|
|
||||||
dev->addr_assign_type &= ~NET_ADDR_RANDOM;
|
|
||||||
memcpy(dev->dev_addr, addr->sa_data, ETH_ALEN);
|
memcpy(dev->dev_addr, addr->sa_data, ETH_ALEN);
|
||||||
|
|
||||||
spin_lock_irq(&pdata->mac_lock);
|
spin_lock_irq(&pdata->mac_lock);
|
||||||
|
|
|
@ -1264,7 +1264,6 @@ static int emac_dev_setmac_addr(struct net_device *ndev, void *addr)
|
||||||
/* Store mac addr in priv and rx channel and set it in EMAC hw */
|
/* Store mac addr in priv and rx channel and set it in EMAC hw */
|
||||||
memcpy(priv->mac_addr, sa->sa_data, ndev->addr_len);
|
memcpy(priv->mac_addr, sa->sa_data, ndev->addr_len);
|
||||||
memcpy(ndev->dev_addr, sa->sa_data, ndev->addr_len);
|
memcpy(ndev->dev_addr, sa->sa_data, ndev->addr_len);
|
||||||
ndev->addr_assign_type &= ~NET_ADDR_RANDOM;
|
|
||||||
|
|
||||||
/* MAC address is configured only after the interface is enabled. */
|
/* MAC address is configured only after the interface is enabled. */
|
||||||
if (netif_running(ndev)) {
|
if (netif_running(ndev)) {
|
||||||
|
|
|
@ -2195,7 +2195,6 @@ static int tile_net_set_mac_address(struct net_device *dev, void *p)
|
||||||
|
|
||||||
/* ISSUE: Note that "dev_addr" is now a pointer. */
|
/* ISSUE: Note that "dev_addr" is now a pointer. */
|
||||||
memcpy(dev->dev_addr, addr->sa_data, dev->addr_len);
|
memcpy(dev->dev_addr, addr->sa_data, dev->addr_len);
|
||||||
dev->addr_assign_type &= ~NET_ADDR_RANDOM;
|
|
||||||
|
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
|
@ -570,7 +570,6 @@ static int w5100_set_macaddr(struct net_device *ndev, void *addr)
|
||||||
if (!is_valid_ether_addr(sock_addr->sa_data))
|
if (!is_valid_ether_addr(sock_addr->sa_data))
|
||||||
return -EADDRNOTAVAIL;
|
return -EADDRNOTAVAIL;
|
||||||
memcpy(ndev->dev_addr, sock_addr->sa_data, ETH_ALEN);
|
memcpy(ndev->dev_addr, sock_addr->sa_data, ETH_ALEN);
|
||||||
ndev->addr_assign_type &= ~NET_ADDR_RANDOM;
|
|
||||||
w5100_write_macaddr(priv);
|
w5100_write_macaddr(priv);
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
|
@ -490,7 +490,6 @@ static int w5300_set_macaddr(struct net_device *ndev, void *addr)
|
||||||
if (!is_valid_ether_addr(sock_addr->sa_data))
|
if (!is_valid_ether_addr(sock_addr->sa_data))
|
||||||
return -EADDRNOTAVAIL;
|
return -EADDRNOTAVAIL;
|
||||||
memcpy(ndev->dev_addr, sock_addr->sa_data, ETH_ALEN);
|
memcpy(ndev->dev_addr, sock_addr->sa_data, ETH_ALEN);
|
||||||
ndev->addr_assign_type &= ~NET_ADDR_RANDOM;
|
|
||||||
w5300_write_macaddr(priv);
|
w5300_write_macaddr(priv);
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
|
@ -375,7 +375,6 @@ static int macvlan_set_mac_address(struct net_device *dev, void *p)
|
||||||
|
|
||||||
if (!(dev->flags & IFF_UP)) {
|
if (!(dev->flags & IFF_UP)) {
|
||||||
/* Just copy in the new address */
|
/* Just copy in the new address */
|
||||||
dev->addr_assign_type &= ~NET_ADDR_RANDOM;
|
|
||||||
memcpy(dev->dev_addr, addr->sa_data, ETH_ALEN);
|
memcpy(dev->dev_addr, addr->sa_data, ETH_ALEN);
|
||||||
} else {
|
} else {
|
||||||
/* Rehash and update the device filters */
|
/* Rehash and update the device filters */
|
||||||
|
|
|
@ -1500,7 +1500,6 @@ static int team_set_mac_address(struct net_device *dev, void *p)
|
||||||
if (dev->type == ARPHRD_ETHER && !is_valid_ether_addr(addr->sa_data))
|
if (dev->type == ARPHRD_ETHER && !is_valid_ether_addr(addr->sa_data))
|
||||||
return -EADDRNOTAVAIL;
|
return -EADDRNOTAVAIL;
|
||||||
memcpy(dev->dev_addr, addr->sa_data, dev->addr_len);
|
memcpy(dev->dev_addr, addr->sa_data, dev->addr_len);
|
||||||
dev->addr_assign_type &= ~NET_ADDR_RANDOM;
|
|
||||||
rcu_read_lock();
|
rcu_read_lock();
|
||||||
list_for_each_entry_rcu(port, &team->port_list, list)
|
list_for_each_entry_rcu(port, &team->port_list, list)
|
||||||
if (team->ops.port_change_dev_addr)
|
if (team->ops.port_change_dev_addr)
|
||||||
|
@ -1770,7 +1769,6 @@ static void team_setup_by_port(struct net_device *dev,
|
||||||
dev->mtu = port_dev->mtu;
|
dev->mtu = port_dev->mtu;
|
||||||
memcpy(dev->broadcast, port_dev->broadcast, port_dev->addr_len);
|
memcpy(dev->broadcast, port_dev->broadcast, port_dev->addr_len);
|
||||||
memcpy(dev->dev_addr, port_dev->dev_addr, port_dev->addr_len);
|
memcpy(dev->dev_addr, port_dev->dev_addr, port_dev->addr_len);
|
||||||
dev->addr_assign_type &= ~NET_ADDR_RANDOM;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
static int team_dev_type_check_change(struct net_device *dev,
|
static int team_dev_type_check_change(struct net_device *dev,
|
||||||
|
|
|
@ -453,12 +453,10 @@ int cvm_oct_common_init(struct net_device *dev)
|
||||||
if (priv->of_node)
|
if (priv->of_node)
|
||||||
mac = of_get_mac_address(priv->of_node);
|
mac = of_get_mac_address(priv->of_node);
|
||||||
|
|
||||||
if (mac && is_valid_ether_addr(mac)) {
|
if (mac && is_valid_ether_addr(mac))
|
||||||
memcpy(dev->dev_addr, mac, ETH_ALEN);
|
memcpy(dev->dev_addr, mac, ETH_ALEN);
|
||||||
dev->addr_assign_type &= ~NET_ADDR_RANDOM;
|
else
|
||||||
} else {
|
|
||||||
eth_hw_addr_random(dev);
|
eth_hw_addr_random(dev);
|
||||||
}
|
|
||||||
|
|
||||||
/*
|
/*
|
||||||
* Force the interface to use the POW send if always_use_pow
|
* Force the interface to use the POW send if always_use_pow
|
||||||
|
|
|
@ -124,7 +124,6 @@ static int batadv_interface_set_mac_addr(struct net_device *dev, void *p)
|
||||||
batadv_tt_local_add(dev, addr->sa_data, BATADV_NULL_IFINDEX);
|
batadv_tt_local_add(dev, addr->sa_data, BATADV_NULL_IFINDEX);
|
||||||
}
|
}
|
||||||
|
|
||||||
dev->addr_assign_type &= ~NET_ADDR_RANDOM;
|
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -172,7 +172,6 @@ static int br_set_mac_address(struct net_device *dev, void *p)
|
||||||
|
|
||||||
spin_lock_bh(&br->lock);
|
spin_lock_bh(&br->lock);
|
||||||
if (!ether_addr_equal(dev->dev_addr, addr->sa_data)) {
|
if (!ether_addr_equal(dev->dev_addr, addr->sa_data)) {
|
||||||
dev->addr_assign_type &= ~NET_ADDR_RANDOM;
|
|
||||||
memcpy(dev->dev_addr, addr->sa_data, ETH_ALEN);
|
memcpy(dev->dev_addr, addr->sa_data, ETH_ALEN);
|
||||||
br_fdb_change_mac_address(br, addr->sa_data);
|
br_fdb_change_mac_address(br, addr->sa_data);
|
||||||
br_stp_change_bridge_id(br, addr->sa_data);
|
br_stp_change_bridge_id(br, addr->sa_data);
|
||||||
|
|
|
@ -290,8 +290,6 @@ int eth_mac_addr(struct net_device *dev, void *p)
|
||||||
if (!is_valid_ether_addr(addr->sa_data))
|
if (!is_valid_ether_addr(addr->sa_data))
|
||||||
return -EADDRNOTAVAIL;
|
return -EADDRNOTAVAIL;
|
||||||
memcpy(dev->dev_addr, addr->sa_data, ETH_ALEN);
|
memcpy(dev->dev_addr, addr->sa_data, ETH_ALEN);
|
||||||
/* if device marked as NET_ADDR_RANDOM, reset it */
|
|
||||||
dev->addr_assign_type &= ~NET_ADDR_RANDOM;
|
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
EXPORT_SYMBOL(eth_mac_addr);
|
EXPORT_SYMBOL(eth_mac_addr);
|
||||||
|
|
|
@ -69,7 +69,6 @@ static int internal_dev_mac_addr(struct net_device *dev, void *p)
|
||||||
|
|
||||||
if (!is_valid_ether_addr(addr->sa_data))
|
if (!is_valid_ether_addr(addr->sa_data))
|
||||||
return -EADDRNOTAVAIL;
|
return -EADDRNOTAVAIL;
|
||||||
dev->addr_assign_type &= ~NET_ADDR_RANDOM;
|
|
||||||
memcpy(dev->dev_addr, addr->sa_data, dev->addr_len);
|
memcpy(dev->dev_addr, addr->sa_data, dev->addr_len);
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
Загрузка…
Ссылка в новой задаче