locking/Documentation: Use `warning` RST directive
Use the proper RST directive, pointed out by a build warning. Signed-off-by: SeongJae Park <sj38.park@gmail.com> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Will Deacon <will.deacon@arm.com> Cc: akiyks@gmail.com Cc: boqun.feng@gmail.com Cc: dhowells@redhat.com Cc: j.alglave@ucl.ac.uk Cc: linux-arch@vger.kernel.org Cc: luc.maranget@inria.fr Cc: npiggin@gmail.com Cc: parri.andrea@gmail.com Cc: stern@rowland.harvard.edu Link: http://lkml.kernel.org/r/1526338533-6044-8-git-send-email-paulmck@linux.vnet.ibm.com Signed-off-by: Ingo Molnar <mingo@kernel.org>
This commit is contained in:
Родитель
fc7bdc9024
Коммит
173af2613e
|
@ -466,10 +466,12 @@ Like the above, except that these routines return a boolean which
|
||||||
indicates whether the changed bit was set _BEFORE_ the atomic bit
|
indicates whether the changed bit was set _BEFORE_ the atomic bit
|
||||||
operation.
|
operation.
|
||||||
|
|
||||||
WARNING! It is incredibly important that the value be a boolean,
|
|
||||||
ie. "0" or "1". Do not try to be fancy and save a few instructions by
|
.. warning::
|
||||||
declaring the above to return "long" and just returning something like
|
It is incredibly important that the value be a boolean, ie. "0" or "1".
|
||||||
"old_val & mask" because that will not work.
|
Do not try to be fancy and save a few instructions by declaring the
|
||||||
|
above to return "long" and just returning something like "old_val &
|
||||||
|
mask" because that will not work.
|
||||||
|
|
||||||
For one thing, this return value gets truncated to int in many code
|
For one thing, this return value gets truncated to int in many code
|
||||||
paths using these interfaces, so on 64-bit if the bit is set in the
|
paths using these interfaces, so on 64-bit if the bit is set in the
|
||||||
|
|
Загрузка…
Ссылка в новой задаче