sound/soc/fsl/p1022_ds.c: add missing of_node_put
dma_channel_np has been accessed at this point, so decrease its reference count before leaving the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ identifier x; expression E1!=0,E2,E3,E4; statement S; iterator I; @@ ( if (...) { ... when != of_node_put(x) when != x = E3 when != E3 = x * return ...; } ... when != x = E2 when != I(...,x,...) S if (...) { ... when != x = E4 of_node_put(x); ... return ...; } ) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Acked-by: Liam Girdwood <lrg@ti.com> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
This commit is contained in:
Родитель
5006b31328
Коммит
178b279b64
|
@ -297,8 +297,10 @@ static int get_dma_channel(struct device_node *ssi_np,
|
|||
* dai->platform name should already point to an allocated buffer.
|
||||
*/
|
||||
ret = of_address_to_resource(dma_channel_np, 0, &res);
|
||||
if (ret)
|
||||
if (ret) {
|
||||
of_node_put(dma_channel_np);
|
||||
return ret;
|
||||
}
|
||||
snprintf((char *)dai->platform_name, DAI_NAME_SIZE, "%llx.%s",
|
||||
(unsigned long long) res.start, dma_channel_np->name);
|
||||
|
||||
|
|
Загрузка…
Ссылка в новой задаче