From 2d135dea53fa7e8c9a20ccbac9857e3b9a926f9f Mon Sep 17 00:00:00 2001 From: Jose Abreu Date: Wed, 29 May 2019 10:30:25 +0200 Subject: [PATCH 1/2] net: stmmac: selftests: Fix sparse warning Variable shall be __be16. Fix it. Fixes: 091810dbded9 ("net: stmmac: Introduce selftests support") Reported-by: kbuild test robot Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Signed-off-by: David S. Miller --- drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c index 33dc37c7e1c1..9d9bad5d31bf 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c @@ -114,7 +114,7 @@ static struct sk_buff *stmmac_test_get_udp_skb(struct stmmac_priv *priv, } if (attr->vlan) { - u16 *tag, *proto; + __be16 *tag, *proto; if (!attr->remove_sa) { tag = (void *)ehdr + ETH_HLEN; From aeb4a5e8b350d481dcb082ac9a102e0fea3f4065 Mon Sep 17 00:00:00 2001 From: Jose Abreu Date: Wed, 29 May 2019 10:30:26 +0200 Subject: [PATCH 2/2] net: stmmac: selftests: Use kfree_skb() instead of kfree() kfree_skb() shall be used instead of kfree(). Fix it. Fixes: 091810dbded9 ("net: stmmac: Introduce selftests support") Reported-by: kbuild test robot Reported-by: Dan Carpenter Signed-off-by: Jose Abreu Cc: Joao Pinto Cc: David S. Miller Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Signed-off-by: David S. Miller --- drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c index 9d9bad5d31bf..a97b1ea76438 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c @@ -617,7 +617,7 @@ static int stmmac_test_flowctrl_validate(struct sk_buff *skb, tpriv->ok = true; complete(&tpriv->comp); out: - kfree(skb); + kfree_skb(skb); return 0; }