rtc: rv3032: fix error handling in rv3032_clkout_set_rate()
[ Upstream commitc3336b8ac6
] Do not call rv3032_exit_eerd() if the enter function fails but don't forget to call the exit when the enter succeeds. Fixes:2eeaa532ac
("rtc: rv3032: Add a driver for Microcrystal RV-3032") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Link: https://lore.kernel.org/r/20211012101028.GT2083@kadam Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Родитель
84ea6245dc
Коммит
1976e7b3c0
|
@ -617,11 +617,11 @@ static int rv3032_clkout_set_rate(struct clk_hw *hw, unsigned long rate,
|
|||
|
||||
ret = rv3032_enter_eerd(rv3032, &eerd);
|
||||
if (ret)
|
||||
goto exit_eerd;
|
||||
return ret;
|
||||
|
||||
ret = regmap_write(rv3032->regmap, RV3032_CLKOUT1, hfd & 0xff);
|
||||
if (ret)
|
||||
return ret;
|
||||
goto exit_eerd;
|
||||
|
||||
ret = regmap_write(rv3032->regmap, RV3032_CLKOUT2, RV3032_CLKOUT2_OS |
|
||||
FIELD_PREP(RV3032_CLKOUT2_HFD_MSK, hfd >> 8));
|
||||
|
|
Загрузка…
Ссылка в новой задаче