pinctrl: st: Add of_node_put() before return
Each iteration of for_each_child_of_node puts the previous node, but in the case of a return from the middle of the loop, there is no put, thus causing a memory leak. Hence add an of_node_put before the return in three places. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com> Link: https://lore.kernel.org/r/20190815060609.3056-1-nishkadg.linux@gmail.com Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Родитель
954fc5d204
Коммит
19d17d935b
|
@ -1263,8 +1263,10 @@ static int st_pctl_parse_functions(struct device_node *np,
|
||||||
grp = &info->groups[*grp_index];
|
grp = &info->groups[*grp_index];
|
||||||
*grp_index += 1;
|
*grp_index += 1;
|
||||||
ret = st_pctl_dt_parse_groups(child, grp, info, i++);
|
ret = st_pctl_dt_parse_groups(child, grp, info, i++);
|
||||||
if (ret)
|
if (ret) {
|
||||||
|
of_node_put(child);
|
||||||
return ret;
|
return ret;
|
||||||
|
}
|
||||||
}
|
}
|
||||||
dev_info(info->dev, "Function[%d\t name:%s,\tgroups:%d]\n",
|
dev_info(info->dev, "Function[%d\t name:%s,\tgroups:%d]\n",
|
||||||
index, func->name, func->ngroups);
|
index, func->name, func->ngroups);
|
||||||
|
@ -1624,8 +1626,10 @@ static int st_pctl_probe_dt(struct platform_device *pdev,
|
||||||
if (of_property_read_bool(child, "gpio-controller")) {
|
if (of_property_read_bool(child, "gpio-controller")) {
|
||||||
const char *bank_name = NULL;
|
const char *bank_name = NULL;
|
||||||
ret = st_gpiolib_register_bank(info, bank, child);
|
ret = st_gpiolib_register_bank(info, bank, child);
|
||||||
if (ret)
|
if (ret) {
|
||||||
|
of_node_put(child);
|
||||||
return ret;
|
return ret;
|
||||||
|
}
|
||||||
|
|
||||||
k = info->banks[bank].range.pin_base;
|
k = info->banks[bank].range.pin_base;
|
||||||
bank_name = info->banks[bank].range.name;
|
bank_name = info->banks[bank].range.name;
|
||||||
|
@ -1642,6 +1646,7 @@ static int st_pctl_probe_dt(struct platform_device *pdev,
|
||||||
i++, &grp_index);
|
i++, &grp_index);
|
||||||
if (ret) {
|
if (ret) {
|
||||||
dev_err(&pdev->dev, "No functions found.\n");
|
dev_err(&pdev->dev, "No functions found.\n");
|
||||||
|
of_node_put(child);
|
||||||
return ret;
|
return ret;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
Загрузка…
Ссылка в новой задаче