[media] drivers/media/dvb-frontends/lg2160.c: Removes useless kfree()
Remove useless kfree() and clean up code related to the removal. The semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r exists@ position p1,p2; expression x; @@ if (x@p1 == NULL) { ... kfree@p2(x); ... return ...; } @unchanged exists@ position r.p1,r.p2; expression e <= r.x,x,e1; iterator I; statement S; @@ if (x@p1 == NULL) { ... when != I(x,...) S when != e = e1 when != e += e1 when != e -= e1 when != ++e when != --e when != e++ when != e-- when != &e kfree@p2(x); ... return ...; } @ok depends on unchanged exists@ position any r.p1; position r.p2; expression x; @@ ... when != true x@p1 == NULL kfree@p2(x); @depends on !ok && unchanged@ position r.p2; expression x; @@ *kfree@p2(x); // </smpl> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Родитель
3f037426d6
Коммит
1a5d2da113
|
@ -1421,8 +1421,8 @@ struct dvb_frontend *lg2160_attach(const struct lg2160_config *config,
|
|||
config ? config->i2c_addr : 0);
|
||||
|
||||
state = kzalloc(sizeof(struct lg216x_state), GFP_KERNEL);
|
||||
if (state == NULL)
|
||||
goto fail;
|
||||
if (!state)
|
||||
return NULL;
|
||||
|
||||
state->cfg = config;
|
||||
state->i2c_adap = i2c_adap;
|
||||
|
@ -1449,10 +1449,6 @@ struct dvb_frontend *lg2160_attach(const struct lg2160_config *config,
|
|||
state->frontend.dtv_property_cache.atscmh_parade_id = 1;
|
||||
|
||||
return &state->frontend;
|
||||
fail:
|
||||
lg_warn("unable to detect LG216x hardware\n");
|
||||
kfree(state);
|
||||
return NULL;
|
||||
}
|
||||
EXPORT_SYMBOL(lg2160_attach);
|
||||
|
||||
|
|
Загрузка…
Ссылка в новой задаче