[media] xc4000: Use kcalloc instead of kzalloc to allocate array
The advantage of kcalloc is, that will prevent integer overflows which could result from the multiplication of number of elements and size and it is also a bit nicer to read. The semantic patch that makes this change is available in https://lkml.org/lkml/2011/11/25/107 Signed-off-by: Thomas Meyer <thomas@m3y3r.de> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Родитель
9884d7bea7
Коммит
1b7acf0ccd
|
@ -311,7 +311,7 @@ static int load_all_firmwares(struct dvb_frontend *fe)
|
|||
n_array, fname, name,
|
||||
priv->firm_version >> 8, priv->firm_version & 0xff);
|
||||
|
||||
priv->firm = kzalloc(sizeof(*priv->firm) * n_array, GFP_KERNEL);
|
||||
priv->firm = kcalloc(n_array, sizeof(*priv->firm), GFP_KERNEL);
|
||||
if (priv->firm == NULL) {
|
||||
tuner_err("Not enough memory to load firmware file.\n");
|
||||
rc = -ENOMEM;
|
||||
|
|
|
@ -758,7 +758,7 @@ static int xc4000_fwupload(struct dvb_frontend *fe)
|
|||
n_array, fname, name,
|
||||
priv->firm_version >> 8, priv->firm_version & 0xff);
|
||||
|
||||
priv->firm = kzalloc(sizeof(*priv->firm) * n_array, GFP_KERNEL);
|
||||
priv->firm = kcalloc(n_array, sizeof(*priv->firm), GFP_KERNEL);
|
||||
if (priv->firm == NULL) {
|
||||
printk(KERN_ERR "Not enough memory to load firmware file.\n");
|
||||
rc = -ENOMEM;
|
||||
|
|
Загрузка…
Ссылка в новой задаче