iscsi-target: make some temporary buffers larger
My static checker complains because we use sprintf() to print some unsigned ints into 10 byte buffers. In theory unsigned ints can take 10 characters and we need another for the terminator. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
This commit is contained in:
Родитель
1810053e8d
Коммит
1be2956d30
|
@ -1095,11 +1095,11 @@ static int iscsi_check_acceptor_state(struct iscsi_param *param, char *value,
|
||||||
SET_PSTATE_REPLY_OPTIONAL(param);
|
SET_PSTATE_REPLY_OPTIONAL(param);
|
||||||
}
|
}
|
||||||
} else if (IS_TYPE_NUMBER(param)) {
|
} else if (IS_TYPE_NUMBER(param)) {
|
||||||
char *tmpptr, buf[10];
|
char *tmpptr, buf[11];
|
||||||
u32 acceptor_value = simple_strtoul(param->value, &tmpptr, 0);
|
u32 acceptor_value = simple_strtoul(param->value, &tmpptr, 0);
|
||||||
u32 proposer_value = simple_strtoul(value, &tmpptr, 0);
|
u32 proposer_value = simple_strtoul(value, &tmpptr, 0);
|
||||||
|
|
||||||
memset(buf, 0, 10);
|
memset(buf, 0, sizeof(buf));
|
||||||
|
|
||||||
if (!strcmp(param->name, MAXCONNECTIONS) ||
|
if (!strcmp(param->name, MAXCONNECTIONS) ||
|
||||||
!strcmp(param->name, MAXBURSTLENGTH) ||
|
!strcmp(param->name, MAXBURSTLENGTH) ||
|
||||||
|
@ -1503,8 +1503,8 @@ static int iscsi_enforce_integrity_rules(
|
||||||
FirstBurstLength = simple_strtoul(param->value,
|
FirstBurstLength = simple_strtoul(param->value,
|
||||||
&tmpptr, 0);
|
&tmpptr, 0);
|
||||||
if (FirstBurstLength > MaxBurstLength) {
|
if (FirstBurstLength > MaxBurstLength) {
|
||||||
char tmpbuf[10];
|
char tmpbuf[11];
|
||||||
memset(tmpbuf, 0, 10);
|
memset(tmpbuf, 0, sizeof(tmpbuf));
|
||||||
sprintf(tmpbuf, "%u", MaxBurstLength);
|
sprintf(tmpbuf, "%u", MaxBurstLength);
|
||||||
if (iscsi_update_param_value(param, tmpbuf))
|
if (iscsi_update_param_value(param, tmpbuf))
|
||||||
return -1;
|
return -1;
|
||||||
|
|
Загрузка…
Ссылка в новой задаче