amd-xgbe: Fix maximum GPIO value check
The GPIO support in the hardware allows for up to 16 GPIO pins, enumerated from 0 to 15. The driver uses the wrong value (16) to validate the GPIO pin range in the routines to set and clear the GPIO output pins. Update the code to use the correct value (15). Reported-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Родитель
5e4cbaa7fb
Коммит
1c1f619e45
|
@ -1099,7 +1099,7 @@ static int xgbe_clr_gpio(struct xgbe_prv_data *pdata, unsigned int gpio)
|
|||
{
|
||||
unsigned int reg;
|
||||
|
||||
if (gpio > 16)
|
||||
if (gpio > 15)
|
||||
return -EINVAL;
|
||||
|
||||
reg = XGMAC_IOREAD(pdata, MAC_GPIOSR);
|
||||
|
@ -1114,7 +1114,7 @@ static int xgbe_set_gpio(struct xgbe_prv_data *pdata, unsigned int gpio)
|
|||
{
|
||||
unsigned int reg;
|
||||
|
||||
if (gpio > 16)
|
||||
if (gpio > 15)
|
||||
return -EINVAL;
|
||||
|
||||
reg = XGMAC_IOREAD(pdata, MAC_GPIOSR);
|
||||
|
|
Загрузка…
Ссылка в новой задаче