HID: picolcd_core: validate output report details

A HID device could send a malicious output report that would cause the
picolcd HID driver to trigger a NULL dereference during attr file writing.

[jkosina@suse.cz: changed

	report->maxfield < 1

to

	report->maxfield != 1

as suggested by Bruno].

CVE-2013-2899

Signed-off-by: Kees Cook <keescook@chromium.org>
Cc: stable@kernel.org
Reviewed-by: Bruno Prémont <bonbons@linux-vserver.org>
Acked-by: Bruno Prémont <bonbons@linux-vserver.org>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
This commit is contained in:
Kees Cook 2013-08-28 22:31:52 +02:00 коммит произвёл Jiri Kosina
Родитель 9e89102573
Коммит 1e87a2456b
1 изменённых файлов: 1 добавлений и 1 удалений

Просмотреть файл

@ -290,7 +290,7 @@ static ssize_t picolcd_operation_mode_store(struct device *dev,
buf += 10; buf += 10;
cnt -= 10; cnt -= 10;
} }
if (!report) if (!report || report->maxfield != 1)
return -EINVAL; return -EINVAL;
while (cnt > 0 && (buf[cnt-1] == '\n' || buf[cnt-1] == '\r')) while (cnt > 0 && (buf[cnt-1] == '\n' || buf[cnt-1] == '\r'))