usb: ulpi: Automatically set driver::owner with ulpi_driver_register()
Let's follow other driver registration functions and automatically set the driver's owner member to THIS_MODULE when ulpi_driver_register() is called. This allows ulpi driver writers to forget about this boiler plate detail and avoids common bugs in the process. Signed-off-by: Stephen Boyd <stephen.boyd@linaro.org> Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Родитель
3cc7e7b787
Коммит
1ebe88d38d
|
@ -127,16 +127,17 @@ static struct device_type ulpi_dev_type = {
|
|||
*
|
||||
* Registers a driver with the ULPI bus.
|
||||
*/
|
||||
int ulpi_register_driver(struct ulpi_driver *drv)
|
||||
int __ulpi_register_driver(struct ulpi_driver *drv, struct module *module)
|
||||
{
|
||||
if (!drv->probe)
|
||||
return -EINVAL;
|
||||
|
||||
drv->driver.owner = module;
|
||||
drv->driver.bus = &ulpi_bus;
|
||||
|
||||
return driver_register(&drv->driver);
|
||||
}
|
||||
EXPORT_SYMBOL_GPL(ulpi_register_driver);
|
||||
EXPORT_SYMBOL_GPL(__ulpi_register_driver);
|
||||
|
||||
/**
|
||||
* ulpi_unregister_driver - unregister a driver with the ULPI bus
|
||||
|
|
|
@ -47,7 +47,11 @@ struct ulpi_driver {
|
|||
|
||||
#define to_ulpi_driver(d) container_of(d, struct ulpi_driver, driver)
|
||||
|
||||
int ulpi_register_driver(struct ulpi_driver *drv);
|
||||
/*
|
||||
* use a macro to avoid include chaining to get THIS_MODULE
|
||||
*/
|
||||
#define ulpi_register_driver(drv) __ulpi_register_driver(drv, THIS_MODULE)
|
||||
int __ulpi_register_driver(struct ulpi_driver *drv, struct module *module);
|
||||
void ulpi_unregister_driver(struct ulpi_driver *drv);
|
||||
|
||||
#define module_ulpi_driver(__ulpi_driver) \
|
||||
|
|
Загрузка…
Ссылка в новой задаче