gpio: da9052: Be sure to clamp return value
As we want gpio_chip .get() calls to be able to return negative error codes and propagate to drivers, we need to go over all drivers and make sure their return values are clamped to [0,1]. We do this by using the ret = !!(val) design pattern. Cc: Ashish Jangam <ashish.jangam@kpitcummins.com> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Родитель
50e8df09e4
Коммит
1f66adfb5e
|
@ -89,15 +89,12 @@ static int da9052_gpio_get(struct gpio_chip *gc, unsigned offset)
|
|||
DA9052_STATUS_D_REG);
|
||||
if (ret < 0)
|
||||
return ret;
|
||||
if (ret & (1 << DA9052_GPIO_SHIFT_COUNT(offset)))
|
||||
return 1;
|
||||
else
|
||||
return 0;
|
||||
return !!(ret & (1 << DA9052_GPIO_SHIFT_COUNT(offset)));
|
||||
case DA9052_OUTPUT_PUSHPULL:
|
||||
if (da9052_gpio_port_odd(offset))
|
||||
return ret & DA9052_GPIO_ODD_PORT_MODE;
|
||||
return !!(ret & DA9052_GPIO_ODD_PORT_MODE);
|
||||
else
|
||||
return ret & DA9052_GPIO_EVEN_PORT_MODE;
|
||||
return !!(ret & DA9052_GPIO_EVEN_PORT_MODE);
|
||||
default:
|
||||
return -EINVAL;
|
||||
}
|
||||
|
|
Загрузка…
Ссылка в новой задаче