firewire: sbp2: remove redundant check for bidi command
[Bart van Asche:] SCSI core never sets cmd->sc_data_direction to DMA_BIDIRECTIONAL; scsi_bidi_cmnd(cmd) should be used instead to test for a bidirectional command. [Christoph Hellwig:] Bidirectional commands won't ever be queued anyway, unless a LLD or transport driver sets QUEUE_FLAG_BIDI. So, simply remove the respective queuecommand check in the SBP-2 transport driver. Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
This commit is contained in:
Родитель
b625a82595
Коммит
1f95f8c9fd
|
@ -1463,17 +1463,6 @@ static int sbp2_scsi_queuecommand(struct Scsi_Host *shost,
|
||||||
struct sbp2_command_orb *orb;
|
struct sbp2_command_orb *orb;
|
||||||
int generation, retval = SCSI_MLQUEUE_HOST_BUSY;
|
int generation, retval = SCSI_MLQUEUE_HOST_BUSY;
|
||||||
|
|
||||||
/*
|
|
||||||
* Bidirectional commands are not yet implemented, and unknown
|
|
||||||
* transfer direction not handled.
|
|
||||||
*/
|
|
||||||
if (cmd->sc_data_direction == DMA_BIDIRECTIONAL) {
|
|
||||||
dev_err(lu_dev(lu), "cannot handle bidirectional command\n");
|
|
||||||
cmd->result = DID_ERROR << 16;
|
|
||||||
cmd->scsi_done(cmd);
|
|
||||||
return 0;
|
|
||||||
}
|
|
||||||
|
|
||||||
orb = kzalloc(sizeof(*orb), GFP_ATOMIC);
|
orb = kzalloc(sizeof(*orb), GFP_ATOMIC);
|
||||||
if (orb == NULL)
|
if (orb == NULL)
|
||||||
return SCSI_MLQUEUE_HOST_BUSY;
|
return SCSI_MLQUEUE_HOST_BUSY;
|
||||||
|
|
Загрузка…
Ссылка в новой задаче