task_work: minor cleanups
Trivial. Remove the unnecessary "work = NULL" initialization and turn read_barrier_depends() into smp_read_barrier_depends() in task_work_cancel(). Signed-off-by: Oleg Nesterov <oleg@redhat.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Родитель
202da40057
Коммит
205e550a0f
|
@ -25,7 +25,7 @@ struct callback_head *
|
||||||
task_work_cancel(struct task_struct *task, task_work_func_t func)
|
task_work_cancel(struct task_struct *task, task_work_func_t func)
|
||||||
{
|
{
|
||||||
struct callback_head **pprev = &task->task_works;
|
struct callback_head **pprev = &task->task_works;
|
||||||
struct callback_head *work = NULL;
|
struct callback_head *work;
|
||||||
unsigned long flags;
|
unsigned long flags;
|
||||||
/*
|
/*
|
||||||
* If cmpxchg() fails we continue without updating pprev.
|
* If cmpxchg() fails we continue without updating pprev.
|
||||||
|
@ -35,7 +35,7 @@ task_work_cancel(struct task_struct *task, task_work_func_t func)
|
||||||
*/
|
*/
|
||||||
raw_spin_lock_irqsave(&task->pi_lock, flags);
|
raw_spin_lock_irqsave(&task->pi_lock, flags);
|
||||||
while ((work = ACCESS_ONCE(*pprev))) {
|
while ((work = ACCESS_ONCE(*pprev))) {
|
||||||
read_barrier_depends();
|
smp_read_barrier_depends();
|
||||||
if (work->func != func)
|
if (work->func != func)
|
||||||
pprev = &work->next;
|
pprev = &work->next;
|
||||||
else if (cmpxchg(pprev, work, work->next) == work)
|
else if (cmpxchg(pprev, work, work->next) == work)
|
||||||
|
|
Загрузка…
Ссылка в новой задаче