[PATCH] tlclk: fix handling of device major
tlclk calls register_chrdev() and permits register_chrdev() to allocate the major, but it promptly forgets what that major was. So if there's no hardware present you still get "telco_clock" appearing in /proc/devices and, I assume, an oops reading /proc/devices if tlclk was a module. Fix. Mark, I'd suggest that that we not call register_chrdev() until _after_ we've established that the hardware is present. Cc: Mark Gross <mgross@linux.intel.com> Cc: <stable@kernel.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
Родитель
3e88c17d40
Коммит
222b9f933a
|
@ -767,6 +767,7 @@ static int __init tlclk_init(void)
|
||||||
printk(KERN_ERR "tlclk: can't get major %d.\n", tlclk_major);
|
printk(KERN_ERR "tlclk: can't get major %d.\n", tlclk_major);
|
||||||
return ret;
|
return ret;
|
||||||
}
|
}
|
||||||
|
tlclk_major = ret;
|
||||||
alarm_events = kzalloc( sizeof(struct tlclk_alarms), GFP_KERNEL);
|
alarm_events = kzalloc( sizeof(struct tlclk_alarms), GFP_KERNEL);
|
||||||
if (!alarm_events)
|
if (!alarm_events)
|
||||||
goto out1;
|
goto out1;
|
||||||
|
|
Загрузка…
Ссылка в новой задаче