livepatch: Improve error handling in klp_disable_func()

In case of func->state or func->old_addr not having expected values,
we'd rather bail out immediately from klp_disable_func().

This can't really happen with the current codebase, but fix this
anyway in the sake of robustness.

[jkosina@suse.com: reworded the changelog a bit]
Signed-off-by: Minfei Huang <mnfhuang@gmail.com>
Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
This commit is contained in:
Minfei Huang 2015-07-14 11:15:37 +08:00 коммит произвёл Jiri Kosina
Родитель 0faef837e4
Коммит 225f58fbcc
1 изменённых файлов: 4 добавлений и 2 удалений

Просмотреть файл

@ -348,8 +348,10 @@ static void klp_disable_func(struct klp_func *func)
{ {
struct klp_ops *ops; struct klp_ops *ops;
WARN_ON(func->state != KLP_ENABLED); if (WARN_ON(func->state != KLP_ENABLED))
WARN_ON(!func->old_addr); return;
if (WARN_ON(!func->old_addr))
return;
ops = klp_find_ops(func->old_addr); ops = klp_find_ops(func->old_addr);
if (WARN_ON(!ops)) if (WARN_ON(!ops))