IB/rdmavt: Only put mmap_info ref if it exists

rvt_create_qp() creates qp->ip only when a qp creation request comes from
userspace (udata is not NULL).  If we exceed the number of available
queue pairs however, the error path always attempts to put a kref to this
structure.  If the requestor is inside the kernel, this leads to a crash.

We fix this by checking that qp->ip is not NULL before caling kref_put().

Signed-off-by: Jim Foraker <foraker1@llnl.gov>
Acked-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Acked-by: Jonathan Toppins <jtoppins@redhat.com>
Acked-by: Alex Estrin <alex.estrin@intel.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
This commit is contained in:
Jim Foraker 2016-11-01 13:44:12 -07:00 коммит произвёл Doug Ledford
Родитель f5eabf5e51
Коммит 22dccc5454
1 изменённых файлов: 2 добавлений и 1 удалений

Просмотреть файл

@ -901,7 +901,8 @@ struct ib_qp *rvt_create_qp(struct ib_pd *ibpd,
return ret; return ret;
bail_ip: bail_ip:
kref_put(&qp->ip->ref, rvt_release_mmap_info); if (qp->ip)
kref_put(&qp->ip->ref, rvt_release_mmap_info);
bail_qpn: bail_qpn:
free_qpn(&rdi->qp_dev->qpn_table, qp->ibqp.qp_num); free_qpn(&rdi->qp_dev->qpn_table, qp->ibqp.qp_num);