rtc: mpc5121: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20230304133028.2135435-18-u.kleine-koenig@pengutronix.de Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
This commit is contained in:
Родитель
99c3a1367d
Коммит
22edbc10a5
|
@ -372,7 +372,7 @@ out_dispose:
|
|||
return err;
|
||||
}
|
||||
|
||||
static int mpc5121_rtc_remove(struct platform_device *op)
|
||||
static void mpc5121_rtc_remove(struct platform_device *op)
|
||||
{
|
||||
struct mpc5121_rtc_data *rtc = platform_get_drvdata(op);
|
||||
struct mpc5121_rtc_regs __iomem *regs = rtc->regs;
|
||||
|
@ -383,8 +383,6 @@ static int mpc5121_rtc_remove(struct platform_device *op)
|
|||
|
||||
irq_dispose_mapping(rtc->irq);
|
||||
irq_dispose_mapping(rtc->irq_periodic);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
#ifdef CONFIG_OF
|
||||
|
@ -402,7 +400,7 @@ static struct platform_driver mpc5121_rtc_driver = {
|
|||
.of_match_table = of_match_ptr(mpc5121_rtc_match),
|
||||
},
|
||||
.probe = mpc5121_rtc_probe,
|
||||
.remove = mpc5121_rtc_remove,
|
||||
.remove_new = mpc5121_rtc_remove,
|
||||
};
|
||||
|
||||
module_platform_driver(mpc5121_rtc_driver);
|
||||
|
|
Загрузка…
Ссылка в новой задаче