i2c: xgene-slimpro: Fix out-of-bounds bug in xgene_slimpro_i2c_xfer()
commit92fbb6d129
upstream. The data->block[0] variable comes from user and is a number between 0-255. Without proper check, the variable may be very large to cause an out-of-bounds when performing memcpy in slimpro_i2c_blkwr. Fix this bug by checking the value of writelen. Fixes:f6505fbabc
("i2c: add SLIMpro I2C device driver on APM X-Gene platform") Signed-off-by: Wei Chen <harperchen1110@gmail.com> Cc: stable@vger.kernel.org Reviewed-by: Andi Shyti <andi.shyti@kernel.org> Signed-off-by: Wolfram Sang <wsa@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Родитель
8e69fae32e
Коммит
272dc775a5
|
@ -307,6 +307,9 @@ static int slimpro_i2c_blkwr(struct slimpro_i2c_dev *ctx, u32 chip,
|
||||||
u32 msg[3];
|
u32 msg[3];
|
||||||
int rc;
|
int rc;
|
||||||
|
|
||||||
|
if (writelen > I2C_SMBUS_BLOCK_MAX)
|
||||||
|
return -EINVAL;
|
||||||
|
|
||||||
memcpy(ctx->dma_buffer, data, writelen);
|
memcpy(ctx->dma_buffer, data, writelen);
|
||||||
paddr = dma_map_single(ctx->dev, ctx->dma_buffer, writelen,
|
paddr = dma_map_single(ctx->dev, ctx->dma_buffer, writelen,
|
||||||
DMA_TO_DEVICE);
|
DMA_TO_DEVICE);
|
||||||
|
|
Загрузка…
Ссылка в новой задаче