IB/ipath: strncpy() doesn't always NUL-terminate
strlcpy() will always null terminate the string. node_desc is not guaranteed to be NUL-terminated so just use memcpy(). Signed-off-by: Roel Kluin <roel.kluin@gmail.com> Signed-off-by: Roland Dreier <rolandd@cisco.com>
This commit is contained in:
Родитель
e07cccf404
Коммит
286b63d096
|
@ -1616,7 +1616,7 @@ static int try_alloc_port(struct ipath_devdata *dd, int port,
|
|||
pd->port_cnt = 1;
|
||||
port_fp(fp) = pd;
|
||||
pd->port_pid = get_pid(task_pid(current));
|
||||
strncpy(pd->port_comm, current->comm, sizeof(pd->port_comm));
|
||||
strlcpy(pd->port_comm, current->comm, sizeof(pd->port_comm));
|
||||
ipath_stats.sps_ports++;
|
||||
ret = 0;
|
||||
} else
|
||||
|
|
|
@ -60,7 +60,7 @@ static int recv_subn_get_nodedescription(struct ib_smp *smp,
|
|||
if (smp->attr_mod)
|
||||
smp->status |= IB_SMP_INVALID_FIELD;
|
||||
|
||||
strncpy(smp->data, ibdev->node_desc, sizeof(smp->data));
|
||||
memcpy(smp->data, ibdev->node_desc, sizeof(smp->data));
|
||||
|
||||
return reply(smp);
|
||||
}
|
||||
|
|
Загрузка…
Ссылка в новой задаче