HID: magicmouse: Fix an error handling path in magicmouse_probe()

commit 33812fc7c8 upstream.

If the timer introduced by the commit below is started, then it must be
deleted in the error handling of the probe. Otherwise it would trigger
once the driver is no more.

Fixes: 0b91b4e4da ("HID: magicmouse: Report battery level over USB")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Tested-by: José Expósito <jose.exposito89@gmail.com>
Reported-by: <syzbot+a437546ec71b04dfb5ac@syzkaller.appspotmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Christophe JAILLET 2021-12-28 22:09:17 +01:00 коммит произвёл Greg Kroah-Hartman
Родитель 00e3d58f50
Коммит 2884aac078
1 изменённых файлов: 1 добавлений и 0 удалений

Просмотреть файл

@ -873,6 +873,7 @@ static int magicmouse_probe(struct hid_device *hdev,
return 0;
err_stop_hw:
del_timer_sync(&msc->battery_timer);
hid_hw_stop(hdev);
return ret;
}