net: hns3: bugfix for rtnl_lock's range in the hclgevf_reset()
Since hclgevf_reset_wait() is used to wait for the hardware to complete
the reset, it is not necessary to hold the rtnl_lock during
hclgevf_reset_wait(). So this patch releases the lock for the duration
of hclgevf_reset_wait().
Fixes: 6988eb2a9b
("net: hns3: Add support to reset the enet/ring mgmt layer")
Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Родитель
a963052e53
Коммит
29118ab962
|
@ -1170,6 +1170,8 @@ static int hclgevf_reset(struct hclgevf_dev *hdev)
|
||||||
/* bring down the nic to stop any ongoing TX/RX */
|
/* bring down the nic to stop any ongoing TX/RX */
|
||||||
hclgevf_notify_client(hdev, HNAE3_DOWN_CLIENT);
|
hclgevf_notify_client(hdev, HNAE3_DOWN_CLIENT);
|
||||||
|
|
||||||
|
rtnl_unlock();
|
||||||
|
|
||||||
/* check if VF could successfully fetch the hardware reset completion
|
/* check if VF could successfully fetch the hardware reset completion
|
||||||
* status from the hardware
|
* status from the hardware
|
||||||
*/
|
*/
|
||||||
|
@ -1181,12 +1183,15 @@ static int hclgevf_reset(struct hclgevf_dev *hdev)
|
||||||
ret);
|
ret);
|
||||||
|
|
||||||
dev_warn(&hdev->pdev->dev, "VF reset failed, disabling VF!\n");
|
dev_warn(&hdev->pdev->dev, "VF reset failed, disabling VF!\n");
|
||||||
|
rtnl_lock();
|
||||||
hclgevf_notify_client(hdev, HNAE3_UNINIT_CLIENT);
|
hclgevf_notify_client(hdev, HNAE3_UNINIT_CLIENT);
|
||||||
|
|
||||||
rtnl_unlock();
|
rtnl_unlock();
|
||||||
return ret;
|
return ret;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
rtnl_lock();
|
||||||
|
|
||||||
/* now, re-initialize the nic client and ae device*/
|
/* now, re-initialize the nic client and ae device*/
|
||||||
ret = hclgevf_reset_stack(hdev);
|
ret = hclgevf_reset_stack(hdev);
|
||||||
if (ret)
|
if (ret)
|
||||||
|
|
Загрузка…
Ссылка в новой задаче