ocxl: fix possible name leak in ocxl_file_register_afu()
If device_register() returns error in ocxl_file_register_afu(),
the name allocated by dev_set_name() need be freed. As comment
of device_register() says, it should use put_device() to give
up the reference in the error path. So fix this by calling
put_device(), then the name can be freed in kobject_cleanup(),
and info is freed in info_release().
Fixes: 75ca758adb
("ocxl: Create a clear delineation between ocxl backend & frontend")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Acked-by: Andrew Donnellan <ajd@linux.ibm.com>
Acked-by: Frederic Barrat <fbarrat@linux.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20221111145929.2429271-1-yangyingliang@huawei.com
This commit is contained in:
Родитель
8bf03f557d
Коммит
295faa1772
|
@ -541,8 +541,11 @@ int ocxl_file_register_afu(struct ocxl_afu *afu)
|
|||
goto err_put;
|
||||
|
||||
rc = device_register(&info->dev);
|
||||
if (rc)
|
||||
goto err_put;
|
||||
if (rc) {
|
||||
free_minor(info);
|
||||
put_device(&info->dev);
|
||||
return rc;
|
||||
}
|
||||
|
||||
rc = ocxl_sysfs_register_afu(info);
|
||||
if (rc)
|
||||
|
|
Загрузка…
Ссылка в новой задаче