perf session: Remove last reference to hists struct
Now perf_session doesn't require that the evsels in its evlist are hists containing ones. Tools that are hists based and want to do per evsel events_stats updates, if at some point this turns into a necessity, should do it in the tool specific code, keeping the session class hists agnostic. Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: Borislav Petkov <bp@suse.de> Cc: David Ahern <dsahern@gmail.com> Cc: Don Zickus <dzickus@redhat.com> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Jean Pihet <jean.pihet@linaro.org> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Mike Galbraith <efault@gmx.de> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Stephane Eranian <eranian@google.com> Link: http://lkml.kernel.org/n/tip-cli1bgwpo82mdikuhy3djsuy@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Родитель
95e8d97e9b
Коммит
2a1731fb85
|
@ -214,6 +214,7 @@ static int __cmd_annotate(struct perf_annotate *ann)
|
||||||
|
|
||||||
if (dump_trace) {
|
if (dump_trace) {
|
||||||
perf_session__fprintf_nr_events(session, stdout);
|
perf_session__fprintf_nr_events(session, stdout);
|
||||||
|
perf_evlist__fprintf_nr_events(session->evlist, stdout);
|
||||||
goto out;
|
goto out;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -487,6 +487,7 @@ static int __cmd_report(struct report *rep)
|
||||||
|
|
||||||
if (dump_trace) {
|
if (dump_trace) {
|
||||||
perf_session__fprintf_nr_events(session, stdout);
|
perf_session__fprintf_nr_events(session, stdout);
|
||||||
|
perf_evlist__fprintf_nr_events(session->evlist, stdout);
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
|
@ -3,6 +3,7 @@
|
||||||
#include "hist.h"
|
#include "hist.h"
|
||||||
#include "session.h"
|
#include "session.h"
|
||||||
#include "sort.h"
|
#include "sort.h"
|
||||||
|
#include "evlist.h"
|
||||||
#include "evsel.h"
|
#include "evsel.h"
|
||||||
#include "annotate.h"
|
#include "annotate.h"
|
||||||
#include <math.h>
|
#include <math.h>
|
||||||
|
@ -1405,6 +1406,21 @@ int hists__link(struct hists *leader, struct hists *other)
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
||||||
|
size_t perf_evlist__fprintf_nr_events(struct perf_evlist *evlist, FILE *fp)
|
||||||
|
{
|
||||||
|
struct perf_evsel *pos;
|
||||||
|
size_t ret = 0;
|
||||||
|
|
||||||
|
evlist__for_each(evlist, pos) {
|
||||||
|
ret += fprintf(fp, "%s stats:\n", perf_evsel__name(pos));
|
||||||
|
ret += events_stats__fprintf(&evsel__hists(pos)->stats, fp);
|
||||||
|
}
|
||||||
|
|
||||||
|
return ret;
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
u64 hists__total_period(struct hists *hists)
|
u64 hists__total_period(struct hists *hists)
|
||||||
{
|
{
|
||||||
return symbol_conf.filter_relative ? hists->stats.total_non_filtered_period :
|
return symbol_conf.filter_relative ? hists->stats.total_non_filtered_period :
|
||||||
|
|
|
@ -139,6 +139,7 @@ size_t events_stats__fprintf(struct events_stats *stats, FILE *fp);
|
||||||
|
|
||||||
size_t hists__fprintf(struct hists *hists, bool show_header, int max_rows,
|
size_t hists__fprintf(struct hists *hists, bool show_header, int max_rows,
|
||||||
int max_cols, float min_pcnt, FILE *fp);
|
int max_cols, float min_pcnt, FILE *fp);
|
||||||
|
size_t perf_evlist__fprintf_nr_events(struct perf_evlist *evlist, FILE *fp);
|
||||||
|
|
||||||
void hists__filter_by_dso(struct hists *hists);
|
void hists__filter_by_dso(struct hists *hists);
|
||||||
void hists__filter_by_thread(struct hists *hists);
|
void hists__filter_by_thread(struct hists *hists);
|
||||||
|
|
|
@ -1375,16 +1375,9 @@ size_t perf_session__fprintf_dsos_buildid(struct perf_session *session, FILE *fp
|
||||||
|
|
||||||
size_t perf_session__fprintf_nr_events(struct perf_session *session, FILE *fp)
|
size_t perf_session__fprintf_nr_events(struct perf_session *session, FILE *fp)
|
||||||
{
|
{
|
||||||
struct perf_evsel *pos;
|
|
||||||
size_t ret = fprintf(fp, "Aggregated stats:\n");
|
size_t ret = fprintf(fp, "Aggregated stats:\n");
|
||||||
|
|
||||||
ret += events_stats__fprintf(&session->stats, fp);
|
ret += events_stats__fprintf(&session->stats, fp);
|
||||||
|
|
||||||
evlist__for_each(session->evlist, pos) {
|
|
||||||
ret += fprintf(fp, "%s stats:\n", perf_evsel__name(pos));
|
|
||||||
ret += events_stats__fprintf(&evsel__hists(pos)->stats, fp);
|
|
||||||
}
|
|
||||||
|
|
||||||
return ret;
|
return ret;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -2,7 +2,6 @@
|
||||||
#define __PERF_SESSION_H
|
#define __PERF_SESSION_H
|
||||||
|
|
||||||
#include "trace-event.h"
|
#include "trace-event.h"
|
||||||
#include "hist.h"
|
|
||||||
#include "event.h"
|
#include "event.h"
|
||||||
#include "header.h"
|
#include "header.h"
|
||||||
#include "machine.h"
|
#include "machine.h"
|
||||||
|
|
Загрузка…
Ссылка в новой задаче