tty: serial: lpuart: Remove unnecessary code from set_mctrl
Currently flow control is not working due to lpuart32_set_mctrl that is clearing TXCTSE bit in all cases. This bit gets earlier setup by lpuart32_set_termios. As I read in Documentation set_mctrl is also not meant for hardware flow control rather than gpio setting and clearing a RTS signal. Therefore I guess it is safe to remove the whole code in lpuart32_set_mctrl. This was tested with console on a i.MX8QXP SoC. Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com> Reviewed-by: Fugang Duan <fugang.duan@nxp.com> Link: https://lore.kernel.org/r/20191017141428.10330-1-philippe.schenker@toradex.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Родитель
c2a5521971
Коммит
2b30efe2e8
|
@ -1333,18 +1333,7 @@ static void lpuart_set_mctrl(struct uart_port *port, unsigned int mctrl)
|
||||||
|
|
||||||
static void lpuart32_set_mctrl(struct uart_port *port, unsigned int mctrl)
|
static void lpuart32_set_mctrl(struct uart_port *port, unsigned int mctrl)
|
||||||
{
|
{
|
||||||
unsigned long temp;
|
|
||||||
|
|
||||||
temp = lpuart32_read(port, UARTMODIR) &
|
|
||||||
~(UARTMODIR_RXRTSE | UARTMODIR_TXCTSE);
|
|
||||||
|
|
||||||
if (mctrl & TIOCM_RTS)
|
|
||||||
temp |= UARTMODIR_RXRTSE;
|
|
||||||
|
|
||||||
if (mctrl & TIOCM_CTS)
|
|
||||||
temp |= UARTMODIR_TXCTSE;
|
|
||||||
|
|
||||||
lpuart32_write(port, temp, UARTMODIR);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
static void lpuart_break_ctl(struct uart_port *port, int break_state)
|
static void lpuart_break_ctl(struct uart_port *port, int break_state)
|
||||||
|
|
Загрузка…
Ссылка в новой задаче