brcmfmac: fix clearing entry IPv6 address

When IPv6 address is to be cleared there is a possible out of
bound access. But also the clearing of the last entry and the
adjustment of total number of stored IPv6 addresses is not
updated. This patch fixes that bug. Bug was found using coverity.

Reviewed-by: Arend Van Spriel <arend.vanspriel@broadcom.com>
Reviewed-by: Franky Lin <franky.lin@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesberts@broadcom.com>
Signed-off-by: Hante Meuleman <hante.meuleman@broadcom.com>
Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
This commit is contained in:
Hante Meuleman 2016-09-19 12:09:57 +01:00 коммит произвёл Kalle Valo
Родитель 835680b82f
Коммит 2b7425f362
1 изменённых файлов: 5 добавлений и 2 удалений

Просмотреть файл

@ -873,9 +873,12 @@ static int brcmf_inet6addr_changed(struct notifier_block *nb,
}
break;
case NETDEV_DOWN:
if (i < NDOL_MAX_ENTRIES)
for (; i < ifp->ipv6addr_idx; i++)
if (i < NDOL_MAX_ENTRIES) {
for (; i < ifp->ipv6addr_idx - 1; i++)
table[i] = table[i + 1];
memset(&table[i], 0, sizeof(table[i]));
ifp->ipv6addr_idx--;
}
break;
default:
break;