media: venus: firmware: fix leaked of_node references
The call to of_parse_phandle returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings: drivers/media/platform/qcom/venus/firmware.c:90:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 82, but without a corresponding object release within this function. drivers/media/platform/qcom/venus/firmware.c:94:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 82, but without a corresponding object release within this function. drivers/media/platform/qcom/venus/firmware.c:128:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 82, but without a corresponding object release within this function. Signed-off-by: Wen Yang <wen.yang99@zte.com.cn> Acked-by: Stanimir Varbanov <stanimir.varbanov@linaro.org> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
This commit is contained in:
Родитель
4a96f5e10e
Коммит
2c41cc0be0
|
@ -87,11 +87,11 @@ static int venus_load_fw(struct venus_core *core, const char *fwname,
|
|||
|
||||
ret = of_address_to_resource(node, 0, &r);
|
||||
if (ret)
|
||||
return ret;
|
||||
goto err_put_node;
|
||||
|
||||
ret = request_firmware(&mdt, fwname, dev);
|
||||
if (ret < 0)
|
||||
return ret;
|
||||
goto err_put_node;
|
||||
|
||||
fw_size = qcom_mdt_get_size(mdt);
|
||||
if (fw_size < 0) {
|
||||
|
@ -125,6 +125,8 @@ static int venus_load_fw(struct venus_core *core, const char *fwname,
|
|||
memunmap(mem_va);
|
||||
err_release_fw:
|
||||
release_firmware(mdt);
|
||||
err_put_node:
|
||||
of_node_put(node);
|
||||
return ret;
|
||||
}
|
||||
|
||||
|
|
Загрузка…
Ссылка в новой задаче