UBIFS: do not write master node if need recovery
The commits781c571
("UBIFS: intialize LPT earlier") and0980119
("UBIFS: fix-up free space earlier") move some initialization before marking the master node dirty. But the modification changes the conditions of writing master. If unclean umount happens, ubifs may fail when mounting. But trying to mount it will write new master nodes on the flash. This is useless but increasing sqnum. So check need_recovery before writing master node, and don't create new master node if filesystem needs recovery. The behavour of the bug shows at: http://lists.infradead.org/pipermail/linux-mtd/2015-February/057712.html Signed-off-by: Sheng Yong <shengyong1@huawei.com> Reviewed-by: Ben Gardiner <ben.l.gardiner@gmail.com> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
This commit is contained in:
Родитель
9401a795c6
Коммит
2c84599ca4
|
@ -1284,7 +1284,7 @@ static int mount_ubifs(struct ubifs_info *c)
|
|||
goto out_lpt;
|
||||
}
|
||||
|
||||
if (!c->ro_mount) {
|
||||
if (!c->ro_mount && !c->need_recovery) {
|
||||
/*
|
||||
* Set the "dirty" flag so that if we reboot uncleanly we
|
||||
* will notice this immediately on the next mount.
|
||||
|
|
Загрузка…
Ссылка в новой задаче