From 2d4d3b5d45f2885ec7e7ecd149ce7b975f4964dd Mon Sep 17 00:00:00 2001 From: Paul Gortmaker Date: Sat, 29 Oct 2016 16:38:42 -0400 Subject: [PATCH] blackfin: make-bf561/coreb.c explicitly non-modular The Kconfig currently controlling compilation of this code is: config BF561_COREB bool "Enable Core B loader" ...meaning that it currently is not being built as a module by anyone. Lets remove the modular code that is essentially orphaned, so that when reading the driver there is no doubt it is builtin-only. Since module_misc_device translates to device_initcall in the non-modular case, the init ordering remains unchanged with this commit. We also delete the MODULE_LICENSE tag etc. since all that information was (or is now) contained at the top of the file in the comments. Cc: Bas Vermeulen Cc: Steven Miao Signed-off-by: Paul Gortmaker Signed-off-by: Greg Kroah-Hartman --- arch/blackfin/mach-bf561/coreb.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/arch/blackfin/mach-bf561/coreb.c b/arch/blackfin/mach-bf561/coreb.c index 8a2543c654b3..cf27554e76bf 100644 --- a/arch/blackfin/mach-bf561/coreb.c +++ b/arch/blackfin/mach-bf561/coreb.c @@ -1,4 +1,6 @@ /* Load firmware into Core B on a BF561 + * + * Author: Bas Vermeulen * * Copyright 2004-2009 Analog Devices Inc. * Licensed under the GPL-2 or later. @@ -14,9 +16,9 @@ #include #include +#include #include #include -#include #define CMD_COREB_START _IO('b', 0) #define CMD_COREB_STOP _IO('b', 1) @@ -59,8 +61,4 @@ static struct miscdevice coreb_dev = { .name = "coreb", .fops = &coreb_fops, }; -module_misc_device(coreb_dev); - -MODULE_AUTHOR("Bas Vermeulen "); -MODULE_DESCRIPTION("BF561 Core B Support"); -MODULE_LICENSE("GPL"); +builtin_misc_device(coreb_dev);