dm cache policy smq: don't do any writebacks unless IDLE

If there are no clean blocks to be demoted the writeback will be
triggered at that point.  Preemptively writing back can hurt high IO
load scenarios.

Signed-off-by: Joe Thornber <ejt@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
This commit is contained in:
Joe Thornber 2017-05-11 09:09:04 -04:00 коммит произвёл Mike Snitzer
Родитель 49b7f76890
Коммит 2e63309507
1 изменённых файлов: 4 добавлений и 5 удалений

Просмотреть файл

@ -1120,8 +1120,6 @@ static bool clean_target_met(struct smq_policy *mq, bool idle)
* Cache entries may not be populated. So we cannot rely on the * Cache entries may not be populated. So we cannot rely on the
* size of the clean queue. * size of the clean queue.
*/ */
unsigned nr_clean;
if (idle) { if (idle) {
/* /*
* We'd like to clean everything. * We'd like to clean everything.
@ -1129,9 +1127,10 @@ static bool clean_target_met(struct smq_policy *mq, bool idle)
return q_size(&mq->dirty) == 0u; return q_size(&mq->dirty) == 0u;
} }
nr_clean = from_cblock(mq->cache_size) - q_size(&mq->dirty); /*
return (nr_clean + btracker_nr_writebacks_queued(mq->bg_work)) >= * If we're busy we don't worry about cleaning at all.
percent_to_target(mq, CLEAN_TARGET); */
return true;
} }
static bool free_target_met(struct smq_policy *mq) static bool free_target_met(struct smq_policy *mq)