lightnvm: fix uninitialized pointer in nvm_remove_tgt()
With gcc 4.1:
drivers/lightnvm/core.c: In function ‘nvm_remove_tgt’:
drivers/lightnvm/core.c:510: warning: ‘t’ is used uninitialized in this function
Indeed, if no NVM devices have been registered, t will be an
uninitialized pointer, and may be dereferenced later. A call to
nvm_remove_tgt() can be triggered from userspace by issuing the
NVM_DEV_REMOVE ioctl on the lightnvm control device.
Fix this by preinitializing t to NULL.
Fixes: 843f2edbdd
("lightnvm: do not remove instance under global lock")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Matias Bjørling <mb@lightnvm.io>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
Родитель
510fd8ea98
Коммит
2f5af4ab7d
|
@ -478,7 +478,7 @@ static void __nvm_remove_target(struct nvm_target *t, bool graceful)
|
|||
*/
|
||||
static int nvm_remove_tgt(struct nvm_ioctl_remove *remove)
|
||||
{
|
||||
struct nvm_target *t;
|
||||
struct nvm_target *t = NULL;
|
||||
struct nvm_dev *dev;
|
||||
|
||||
down_read(&nvm_lock);
|
||||
|
|
Загрузка…
Ссылка в новой задаче