From 2f7aacf795e0192648b51674aef90e755e02408c Mon Sep 17 00:00:00 2001 From: Wei Yongjun Date: Mon, 15 Jan 2018 10:41:53 +0000 Subject: [PATCH] firmware: arm_sdei: Fix return value check in sdei_present_dt() In case of error, the function of_platform_device_create() returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test. Fixes: 677a60bd2003 ("firmware: arm_sdei: Discover SDEI support via ACPI") Acked-by: James Morse Signed-off-by: Wei Yongjun Signed-off-by: Catalin Marinas --- drivers/firmware/arm_sdei.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/arm_sdei.c b/drivers/firmware/arm_sdei.c index 8f6563c595e5..1ea71640fdc2 100644 --- a/drivers/firmware/arm_sdei.c +++ b/drivers/firmware/arm_sdei.c @@ -1023,7 +1023,7 @@ static bool __init sdei_present_dt(void) pdev = of_platform_device_create(np, sdei_driver.driver.name, NULL); of_node_put(np); - if (IS_ERR(pdev)) + if (!pdev) return false; return true;