powerpc/83xx: Fix the interrupt loss problem on ipic
The interrupt pending register is write 1 clear. If there are more than one external interrupts pending at the same time, acking the first interrupt by reading pending register then OR the corresponding bit and write back to pending register will also clear other interrupt pending bits. That will cause loss of interrupt. Signed-off-by: Da Yu <dayu@datangmobile.cn> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
This commit is contained in:
Родитель
1ab082d7cb
Коммит
30c404699d
|
@ -568,8 +568,7 @@ static void ipic_ack_irq(unsigned int virq)
|
||||||
|
|
||||||
spin_lock_irqsave(&ipic_lock, flags);
|
spin_lock_irqsave(&ipic_lock, flags);
|
||||||
|
|
||||||
temp = ipic_read(ipic->regs, ipic_info[src].ack);
|
temp = 1 << (31 - ipic_info[src].bit);
|
||||||
temp |= (1 << (31 - ipic_info[src].bit));
|
|
||||||
ipic_write(ipic->regs, ipic_info[src].ack, temp);
|
ipic_write(ipic->regs, ipic_info[src].ack, temp);
|
||||||
|
|
||||||
/* mb() can't guarantee that ack is finished. But it does finish
|
/* mb() can't guarantee that ack is finished. But it does finish
|
||||||
|
@ -592,8 +591,7 @@ static void ipic_mask_irq_and_ack(unsigned int virq)
|
||||||
temp &= ~(1 << (31 - ipic_info[src].bit));
|
temp &= ~(1 << (31 - ipic_info[src].bit));
|
||||||
ipic_write(ipic->regs, ipic_info[src].mask, temp);
|
ipic_write(ipic->regs, ipic_info[src].mask, temp);
|
||||||
|
|
||||||
temp = ipic_read(ipic->regs, ipic_info[src].ack);
|
temp = 1 << (31 - ipic_info[src].bit);
|
||||||
temp |= (1 << (31 - ipic_info[src].bit));
|
|
||||||
ipic_write(ipic->regs, ipic_info[src].ack, temp);
|
ipic_write(ipic->regs, ipic_info[src].ack, temp);
|
||||||
|
|
||||||
/* mb() can't guarantee that ack is finished. But it does finish
|
/* mb() can't guarantee that ack is finished. But it does finish
|
||||||
|
|
Загрузка…
Ссылка в новой задаче