s390/qeth: make af_iucv TX notification call more robust
Calling into socket code is ugly already, at least check whether we are
dealing with the expected sk_family. Only looking at skb->protocol is
bound to cause troubles (consider eg. af_packet).
Fixes: b333293058
("qeth: add support for af_iucv HiperSockets transport")
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Родитель
0d0e2b538c
Коммит
34c7f50f7d
|
@ -33,6 +33,7 @@
|
|||
|
||||
#include <net/iucv/af_iucv.h>
|
||||
#include <net/dsfield.h>
|
||||
#include <net/sock.h>
|
||||
|
||||
#include <asm/ebcdic.h>
|
||||
#include <asm/chpid.h>
|
||||
|
@ -1405,7 +1406,7 @@ static void qeth_notify_skbs(struct qeth_qdio_out_q *q,
|
|||
skb_queue_walk(&buf->skb_list, skb) {
|
||||
QETH_CARD_TEXT_(q->card, 5, "skbn%d", notification);
|
||||
QETH_CARD_TEXT_(q->card, 5, "%lx", (long) skb);
|
||||
if (skb->protocol == htons(ETH_P_AF_IUCV) && skb->sk)
|
||||
if (skb->sk && skb->sk->sk_family == PF_IUCV)
|
||||
iucv_sk(skb->sk)->sk_txnotify(skb, notification);
|
||||
}
|
||||
}
|
||||
|
|
Загрузка…
Ссылка в новой задаче