[IP_TUNNEL]: Don't limit the number of tunnels with generic name explicitly.
Use the added dev_alloc_name() call to create tunnel device name, rather than iterate in a hand-made loop with an artificial limit. Thanks Patrick for noticing this. [ The way this works is, when the device is actually registered, the generic code noticed the '%' in the name and invokes dev_alloc_name() to fully resolve the name. -DaveM ] Signed-off-by: Pavel Emelyanov <xemul@openvz.org> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Родитель
55b01e8681
Коммит
34cc7ba639
|
@ -14,8 +14,6 @@
|
|||
/* capable of receiving packets */
|
||||
#define IP6_TNL_F_CAP_RCV 0x20000
|
||||
|
||||
#define IP6_TNL_MAX 128
|
||||
|
||||
/* IPv6 tunnel */
|
||||
|
||||
struct ip6_tnl {
|
||||
|
|
|
@ -259,16 +259,8 @@ static struct ip_tunnel * ipgre_tunnel_locate(struct ip_tunnel_parm *parms, int
|
|||
|
||||
if (parms->name[0])
|
||||
strlcpy(name, parms->name, IFNAMSIZ);
|
||||
else {
|
||||
int i;
|
||||
for (i=1; i<100; i++) {
|
||||
sprintf(name, "gre%d", i);
|
||||
if (__dev_get_by_name(&init_net, name) == NULL)
|
||||
break;
|
||||
}
|
||||
if (i==100)
|
||||
goto failed;
|
||||
}
|
||||
else
|
||||
sprintf(name, "gre%%d");
|
||||
|
||||
dev = alloc_netdev(sizeof(*t), name, ipgre_tunnel_setup);
|
||||
if (!dev)
|
||||
|
|
|
@ -221,16 +221,8 @@ static struct ip_tunnel * ipip_tunnel_locate(struct ip_tunnel_parm *parms, int c
|
|||
|
||||
if (parms->name[0])
|
||||
strlcpy(name, parms->name, IFNAMSIZ);
|
||||
else {
|
||||
int i;
|
||||
for (i=1; i<100; i++) {
|
||||
sprintf(name, "tunl%d", i);
|
||||
if (__dev_get_by_name(&init_net, name) == NULL)
|
||||
break;
|
||||
}
|
||||
if (i==100)
|
||||
goto failed;
|
||||
}
|
||||
else
|
||||
sprintf(name, "tunl%%d");
|
||||
|
||||
dev = alloc_netdev(sizeof(*t), name, ipip_tunnel_setup);
|
||||
if (dev == NULL)
|
||||
|
|
|
@ -229,18 +229,11 @@ static struct ip6_tnl *ip6_tnl_create(struct ip6_tnl_parm *p)
|
|||
char name[IFNAMSIZ];
|
||||
int err;
|
||||
|
||||
if (p->name[0]) {
|
||||
if (p->name[0])
|
||||
strlcpy(name, p->name, IFNAMSIZ);
|
||||
} else {
|
||||
int i;
|
||||
for (i = 1; i < IP6_TNL_MAX; i++) {
|
||||
sprintf(name, "ip6tnl%d", i);
|
||||
if (__dev_get_by_name(&init_net, name) == NULL)
|
||||
break;
|
||||
}
|
||||
if (i == IP6_TNL_MAX)
|
||||
goto failed;
|
||||
}
|
||||
else
|
||||
sprintf(name, "ip6tnl%%d");
|
||||
|
||||
dev = alloc_netdev(sizeof (*t), name, ip6_tnl_dev_setup);
|
||||
if (dev == NULL)
|
||||
goto failed;
|
||||
|
|
|
@ -164,16 +164,8 @@ static struct ip_tunnel * ipip6_tunnel_locate(struct ip_tunnel_parm *parms, int
|
|||
|
||||
if (parms->name[0])
|
||||
strlcpy(name, parms->name, IFNAMSIZ);
|
||||
else {
|
||||
int i;
|
||||
for (i=1; i<100; i++) {
|
||||
sprintf(name, "sit%d", i);
|
||||
if (__dev_get_by_name(&init_net, name) == NULL)
|
||||
break;
|
||||
}
|
||||
if (i==100)
|
||||
goto failed;
|
||||
}
|
||||
else
|
||||
sprintf(name, "sit%%d");
|
||||
|
||||
dev = alloc_netdev(sizeof(*t), name, ipip6_tunnel_setup);
|
||||
if (dev == NULL)
|
||||
|
|
Загрузка…
Ссылка в новой задаче