ASoC: wm8731: Use devm_regulator_bulk_get()
Using devm_regulator_bulk_get() can make the code cleaner and smaller as we do not need to call regulator_bulk_free() in the error and remove paths. Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> Signed-off-by: Mark Brown <broonie@linaro.org>
This commit is contained in:
Родитель
c9eaa447e7
Коммит
3598aad547
|
@ -586,7 +586,7 @@ static int wm8731_probe(struct snd_soc_codec *codec)
|
|||
for (i = 0; i < ARRAY_SIZE(wm8731->supplies); i++)
|
||||
wm8731->supplies[i].supply = wm8731_supply_names[i];
|
||||
|
||||
ret = regulator_bulk_get(codec->dev, ARRAY_SIZE(wm8731->supplies),
|
||||
ret = devm_regulator_bulk_get(codec->dev, ARRAY_SIZE(wm8731->supplies),
|
||||
wm8731->supplies);
|
||||
if (ret != 0) {
|
||||
dev_err(codec->dev, "Failed to request supplies: %d\n", ret);
|
||||
|
@ -597,7 +597,7 @@ static int wm8731_probe(struct snd_soc_codec *codec)
|
|||
wm8731->supplies);
|
||||
if (ret != 0) {
|
||||
dev_err(codec->dev, "Failed to enable supplies: %d\n", ret);
|
||||
goto err_regulator_get;
|
||||
return ret;
|
||||
}
|
||||
|
||||
ret = wm8731_reset(codec);
|
||||
|
@ -624,8 +624,6 @@ static int wm8731_probe(struct snd_soc_codec *codec)
|
|||
|
||||
err_regulator_enable:
|
||||
regulator_bulk_disable(ARRAY_SIZE(wm8731->supplies), wm8731->supplies);
|
||||
err_regulator_get:
|
||||
regulator_bulk_free(ARRAY_SIZE(wm8731->supplies), wm8731->supplies);
|
||||
|
||||
return ret;
|
||||
}
|
||||
|
@ -638,7 +636,6 @@ static int wm8731_remove(struct snd_soc_codec *codec)
|
|||
wm8731_set_bias_level(codec, SND_SOC_BIAS_OFF);
|
||||
|
||||
regulator_bulk_disable(ARRAY_SIZE(wm8731->supplies), wm8731->supplies);
|
||||
regulator_bulk_free(ARRAY_SIZE(wm8731->supplies), wm8731->supplies);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
|
Загрузка…
Ссылка в новой задаче