crypto: ccree - Remove a useless dma_supported() call
There is no point in calling dma_supported() before calling dma_set_coherent_mask(). This function already calls dma_supported() and returns an error (-EIO) if it fails. So remove the superfluous dma_supported() call. Moreover, setting a larger DMA mask will never fail when setting a smaller one will succeed, so the whole "while" loop can be removed as well. (see [1]) While at it, fix the name of the function reported in a dev_err(). [1]: https://lore.kernel.org/all/YteQ6Vx2C03UtCkG@infradead.org/ Suggested-by: Christoph Hellwig <hch@infradead.org> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Acked-by: Gilad Ben-Yossef <gilad@benyossef.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Родитель
96ec8dfdd0
Коммит
383ce25dd2
|
@ -372,17 +372,10 @@ static int init_cc_resources(struct platform_device *plat_dev)
|
|||
dev->dma_mask = &dev->coherent_dma_mask;
|
||||
|
||||
dma_mask = DMA_BIT_MASK(DMA_BIT_MASK_LEN);
|
||||
while (dma_mask > 0x7fffffffUL) {
|
||||
if (dma_supported(dev, dma_mask)) {
|
||||
rc = dma_set_coherent_mask(dev, dma_mask);
|
||||
if (!rc)
|
||||
break;
|
||||
}
|
||||
dma_mask >>= 1;
|
||||
}
|
||||
|
||||
rc = dma_set_coherent_mask(dev, dma_mask);
|
||||
if (rc) {
|
||||
dev_err(dev, "Failed in dma_set_mask, mask=%llx\n", dma_mask);
|
||||
dev_err(dev, "Failed in dma_set_coherent_mask, mask=%llx\n",
|
||||
dma_mask);
|
||||
return rc;
|
||||
}
|
||||
|
||||
|
|
Загрузка…
Ссылка в новой задаче