sched: Convert BUG_ON()s in try_to_wake_up_local() to WARN_ON_ONCE()s

try_to_wake_up_local() should only be invoked to wake up another
task in the same runqueue and BUG_ON()s are used to enforce the
rule. Missing try_to_wake_up_local() can stall workqueue
execution but such stalls are likely to be finite either by
another work item being queued or the one blocked getting
unblocked.  There's no reason to trigger BUG while holding rq
lock crashing the whole system.

Convert BUG_ON()s in try_to_wake_up_local() to WARN_ON_ONCE()s.

Signed-off-by: Tejun Heo <tj@kernel.org>
Acked-by: Steven Rostedt <rostedt@goodmis.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20130318192234.GD3042@htj.dyndns.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
This commit is contained in:
Tejun Heo 2013-03-18 12:22:34 -07:00 коммит произвёл Ingo Molnar
Родитель 7f6575f1fb
Коммит 383efcd000
1 изменённых файлов: 4 добавлений и 2 удалений

Просмотреть файл

@ -1488,8 +1488,10 @@ static void try_to_wake_up_local(struct task_struct *p)
{ {
struct rq *rq = task_rq(p); struct rq *rq = task_rq(p);
BUG_ON(rq != this_rq()); if (WARN_ON_ONCE(rq != this_rq()) ||
BUG_ON(p == current); WARN_ON_ONCE(p == current))
return;
lockdep_assert_held(&rq->lock); lockdep_assert_held(&rq->lock);
if (!raw_spin_trylock(&p->pi_lock)) { if (!raw_spin_trylock(&p->pi_lock)) {