usb: phy: gpio-vbus: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: Linus Walleij <linus.walleij@linaro.org> Link: https://lore.kernel.org/r/20230319092428.283054-6-u.kleine-koenig@pengutronix.de Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Родитель
a8095f9c52
Коммит
399d011772
|
@ -325,7 +325,7 @@ static int gpio_vbus_probe(struct platform_device *pdev)
|
|||
return 0;
|
||||
}
|
||||
|
||||
static int gpio_vbus_remove(struct platform_device *pdev)
|
||||
static void gpio_vbus_remove(struct platform_device *pdev)
|
||||
{
|
||||
struct gpio_vbus_data *gpio_vbus = platform_get_drvdata(pdev);
|
||||
|
||||
|
@ -333,8 +333,6 @@ static int gpio_vbus_remove(struct platform_device *pdev)
|
|||
cancel_delayed_work_sync(&gpio_vbus->work);
|
||||
|
||||
usb_remove_phy(&gpio_vbus->phy);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
#ifdef CONFIG_PM
|
||||
|
@ -386,7 +384,7 @@ static struct platform_driver gpio_vbus_driver = {
|
|||
.of_match_table = gpio_vbus_of_match,
|
||||
},
|
||||
.probe = gpio_vbus_probe,
|
||||
.remove = gpio_vbus_remove,
|
||||
.remove_new = gpio_vbus_remove,
|
||||
};
|
||||
|
||||
module_platform_driver(gpio_vbus_driver);
|
||||
|
|
Загрузка…
Ссылка в новой задаче