ethtool: always write dev in ethnl_parse_header_dev_get
Commit 0976b888a1
("ethtool: fix null-ptr-deref on ref tracker")
made the write to req_info.dev conditional, but as Eric points out
in a different follow up the structure is often allocated on the
stack and not kzalloc()'d so seems safer to always write the dev,
in case it's garbage on input.
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Родитель
f1d9268e06
Коммит
3bc14ea0d1
|
@ -141,10 +141,9 @@ int ethnl_parse_header_dev_get(struct ethnl_req_info *req_info,
|
||||||
return -EINVAL;
|
return -EINVAL;
|
||||||
}
|
}
|
||||||
|
|
||||||
if (dev) {
|
req_info->dev = dev;
|
||||||
req_info->dev = dev;
|
if (dev)
|
||||||
netdev_tracker_alloc(dev, &req_info->dev_tracker, GFP_KERNEL);
|
netdev_tracker_alloc(dev, &req_info->dev_tracker, GFP_KERNEL);
|
||||||
}
|
|
||||||
req_info->flags = flags;
|
req_info->flags = flags;
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
Загрузка…
Ссылка в новой задаче