brcmfmac: Fix glob_skb leak in brcmf_sdiod_recv_chain
In case brcmf_sdiod_recv_chain() cannot complete a succeful call to
brcmf_sdiod_buffrw, we would be leaking glom_skb and not free it as we
should, fix this.
Reported-by: coverity (CID 1164856)
Fixes: a413e39a38
("brcmfmac: fix brcmf_sdcard_recv_chain() for host without sg support")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
This commit is contained in:
Родитель
cc2d1de06f
Коммит
3bdae81072
|
@ -726,8 +726,10 @@ int brcmf_sdiod_recv_chain(struct brcmf_sdio_dev *sdiodev,
|
||||||
return -ENOMEM;
|
return -ENOMEM;
|
||||||
err = brcmf_sdiod_buffrw(sdiodev, SDIO_FUNC_2, false, addr,
|
err = brcmf_sdiod_buffrw(sdiodev, SDIO_FUNC_2, false, addr,
|
||||||
glom_skb);
|
glom_skb);
|
||||||
if (err)
|
if (err) {
|
||||||
|
brcmu_pkt_buf_free_skb(glom_skb);
|
||||||
goto done;
|
goto done;
|
||||||
|
}
|
||||||
|
|
||||||
skb_queue_walk(pktq, skb) {
|
skb_queue_walk(pktq, skb) {
|
||||||
memcpy(skb->data, glom_skb->data, skb->len);
|
memcpy(skb->data, glom_skb->data, skb->len);
|
||||||
|
|
Загрузка…
Ссылка в новой задаче